Issue 243173005: Add SM_CXSIZEFRAME and SM_CXPADDEDBORDER metrics to get window border size.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 243173005: Add SM_CXSIZEFRAME and SM_CXPADDEDBORDER metrics to get window border size. (Closed)

Created:
6 years, 8 months ago by jbauman

Modified:
6 years, 8 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add SM_CXSIZEFRAME and SM_CXPADDEDBORDER metrics to get window border size. Vista added the SM_CXPADDEDBORDER system metric which needs to be included in the border size. The previous code happened to work with 32-bit Chrome because Windows added the padding into SM_CXSIZEFRAME (and set the padding to 0) for backwards compatibility, but with 64-bit that changed. GetSystemMetrics(SM_CXPADDEDBORDER) should always return 0 on XP. BUG=361720 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265329

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -5 lines)			Patch
	M	chrome/browser/ui/views/frame/browser_desktop_window_tree_host_win.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	ui/views/win/hwnd_message_handler.cc	View		3 chunks	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/243173005/1

6 years, 8 months ago (2014-04-22 17:55:02 UTC) #4

Message was sent while issue was closed.

Change committed as 265329

Expand Messages | Collapse Messages