Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1093)

Unified Diff: Source/core/svg/properties/SVGPropertyTearOff.h

Issue 321403004: SVG: Items inserted into list should be made a tear-off. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: LayoutTests Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/svg/properties/SVGPropertyTearOff.h
diff --git a/Source/core/svg/properties/SVGPropertyTearOff.h b/Source/core/svg/properties/SVGPropertyTearOff.h
index caee1657c7733250c7f932545dd139fb8132ce2c..69ca41997dccda32506dfff9ad89a749a4947163 100644
--- a/Source/core/svg/properties/SVGPropertyTearOff.h
+++ b/Source/core/svg/properties/SVGPropertyTearOff.h
@@ -83,6 +83,15 @@ public:
return m_attributeName;
}
+ void makeTearOff(SVGElement* contextElement, const QualifiedName& attributeName)
fs 2014/06/11 08:42:23 I can see where "makeTearOff" comes from, but it m
kouhei (in TOK) 2014/06/12 04:25:28 Yes this isn't a very good name. Trying "attachToS
fs 2014/06/12 08:32:23 Naming is hard, but this new shade is certainly an
+ {
+ ASSERT(!isImmutable());
+ ASSERT(contextElement);
+ ASSERT(attributeName != nullQName());
+ m_contextElement = contextElement;
+ m_attributeName = attributeName;
+ }
+
virtual AnimatedPropertyType type() const = 0;
protected:

Powered by Google App Engine
This is Rietveld 408576698