Chromium Code Reviews| Index: Source/core/svg/SVGPathSegListTearOff.h |
| diff --git a/Source/core/svg/SVGPathSegListTearOff.h b/Source/core/svg/SVGPathSegListTearOff.h |
| index f360f34fca57a23e7a83fd95d0238573f0afad1c..da3046188e8292bbd3ca6be365b5af87aee5d7a9 100644 |
| --- a/Source/core/svg/SVGPathSegListTearOff.h |
| +++ b/Source/core/svg/SVGPathSegListTearOff.h |
| @@ -31,6 +31,7 @@ |
| #ifndef SVGPathSegListTearOff_h |
| #define SVGPathSegListTearOff_h |
| +#include "SVGNames.h" |
| #include "core/svg/SVGPathSegList.h" |
| #include "core/svg/properties/SVGListPropertyTearOffHelper.h" |
| @@ -43,9 +44,12 @@ public: |
| // FIXME: Currently SVGPathSegitself is a tear-off. |
| typedef SVGPathSeg ItemTearOffType; |
| - static PassRefPtr<ItemPropertyType> getValueForInsertionFromTearOff(PassRefPtr<ItemTearOffType> passNewItem) |
| + static PassRefPtr<ItemPropertyType> getValueForInsertionFromTearOff(PassRefPtr<ItemTearOffType> passNewItem, SVGElement* contextElement, const QualifiedName& attributeName) |
| { |
| - return passNewItem; |
| + ASSERT(attributeName == SVGNames::dAttr); |
| + RefPtr<ItemTearOffType> newItem = passNewItem; |
| + newItem->setContextElement(contextElement); |
|
Erik Dahlström (inactive)
2014/06/11 08:31:32
Doesn't this need to set attributeName too? Like i
kouhei (in TOK)
2014/06/12 04:25:28
I think this is correct. SVGAnimateMotionElement d
Erik Dahlström (inactive)
2014/06/12 08:47:04
Fair enough for pathseglist then, but the other li
|
| + return newItem.release(); |
| } |
| static PassRefPtr<ItemTearOffType> createTearOff(PassRefPtr<ItemPropertyType> passValue, SVGElement* contextElement, PropertyIsAnimValType, const QualifiedName&) |