SVG: Items inserted into list should be made a tear-off.

Source/core/svg/SVGPathSegListTearOff.h

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef SVGPathSegListTearOff_h
 #define SVGPathSegListTearOff_h
 
+#include "SVGNames.h"
 #include "core/svg/SVGPathSegList.h"
 #include "core/svg/properties/SVGListPropertyTearOffHelper.h"
 
 namespace WebCore {
 
 template<>
 class ListItemPropertyTraits<SVGPathSeg> {
 public:
     typedef SVGPathSeg ItemPropertyType;
     // FIXME: Currently SVGPathSegitself is a tear-off.
     typedef SVGPathSeg ItemTearOffType;
 
-    static PassRefPtr<ItemPropertyType> getValueForInsertionFromTearOff(PassRefPtr<ItemTearOffType> passNewItem)
+    static PassRefPtr<ItemPropertyType> getValueForInsertionFromTearOff(PassRefPtr<ItemTearOffType> passNewItem, SVGElement* contextElement, const QualifiedName& attributeName)
     {
-        return passNewItem;
+        ASSERT(attributeName == SVGNames::dAttr);
+        RefPtr<ItemTearOffType> newItem = passNewItem;
+        newItem->setContextElement(contextElement);

[Erik Dahlström (inactive), 2014/06/11 08:31:32]

Doesn't this need to set attributeName too? Like if you move a pathseglist from
an animateMotion element to a path element for example ("path" to "d"
attribute). Please add a test like that. Does it also need to update the
PropertyIsAnimValType flag?

[kouhei (in TOK), 2014/06/12 04:25:28]

I think this is correct. SVGAnimateMotionElement do not expose DOM (both in
SVG{1.1,2} spec and in Blink impl), so the only attributeName is dAttr.

[Erik Dahlström (inactive), 2014/06/12 08:47:04]

Fair enough for pathseglist then, but the other lists share the same issue.
Let's say you move an SVGLength from an x to an y attribute for example.

+        return newItem.release();
     }
 
     static PassRefPtr<ItemTearOffType> createTearOff(PassRefPtr<ItemPropertyType> passValue, SVGElement* contextElement, PropertyIsAnimValType, const QualifiedName&)
     {
         RefPtr<SVGPathSeg> value = passValue;
         value->setContextElement(contextElement);
         return value.release();
     }
 };
 
@@ skipping 10 matching lines @@
     SVGPathSegListTearOff(PassRefPtr<SVGPathSegList> target, SVGElement* contextElement, PropertyIsAnimValType propertyIsAnimVal, const QualifiedName& attributeName = nullQName())
         : SVGListPropertyTearOffHelper<SVGPathSegListTearOff, SVGPathSegList>(target, contextElement, propertyIsAnimVal, attributeName)
     {
         ScriptWrappable::init(this);
     }
 };
 
 } // namespace WebCore
 
 #endif // SVGPathSegListTearOff_h_