Source/web/WebPagePopupImpl.h - Issue 321373003: Changing animate to beginFrame and use struct rather than naked double to allow extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebPagePopupImpl.h

Issue 321373003: Changing animate to beginFrame and use struct rather than naked double to allow extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Adding another FIXME comment. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebPagePopupImpl.h

diff --git a/Source/web/WebPagePopupImpl.h b/Source/web/WebPagePopupImpl.h

index ff132e3ee764bc75ececbd1a45f5dd87d95c87f8..ff364f077b44f4ad352eab9e33365b65fc7bff70 100644

--- a/Source/web/WebPagePopupImpl.h

+++ b/Source/web/WebPagePopupImpl.h

@@ -70,7 +70,7 @@ public:

private:

// WebWidget functions

virtual WebSize size() OVERRIDE;

- virtual void animate(double) OVERRIDE;

+ virtual void beginFrame(const WebBeginFrameArgs&) OVERRIDE;

virtual void layout() OVERRIDE;

virtual void willCloseLayerTreeView() OVERRIDE;

virtual void paint(WebCanvas*, const WebRect&) OVERRIDE;

« no previous file with comments | « no previous file | Source/web/WebPagePopupImpl.cpp » ('j') | no next file with comments »