Source/web/WebPagePopupImpl.cpp - Issue 321373003: Changing animate to beginFrame and use struct rather than naked double to allow extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebPagePopupImpl.cpp

Issue 321373003: Changing animate to beginFrame and use struct rather than naked double to allow extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Adding another FIXME comment. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebPagePopupImpl.cpp

diff --git a/Source/web/WebPagePopupImpl.cpp b/Source/web/WebPagePopupImpl.cpp

index e03b673c6b831fd25b73511e2f98aab0546c9905..648ba90dfc2b77f2652ff8bb741956325b378f63 100644

--- a/Source/web/WebPagePopupImpl.cpp

+++ b/Source/web/WebPagePopupImpl.cpp

@@ -280,8 +280,10 @@ WebSize WebPagePopupImpl::size()

return m_popupClient->contentSize();

}

-void WebPagePopupImpl::animate(double)

+void WebPagePopupImpl::beginFrame(const WebBeginFrameArgs& frameTime)

{

+ // FIXME: This should use frameTime.lastFrameTimeMonotonic but doing so

+ // breaks tests.

PageWidgetDelegate::animate(m_page.get(), monotonicallyIncreasingTime());

}

« no previous file with comments | « Source/web/WebPagePopupImpl.h ('k') | Source/web/WebPopupMenuImpl.h » ('j') | no next file with comments »