Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2142)

Unified Diff: Source/web/WebPagePopupImpl.cpp

Issue 321373003: Changing animate to beginFrame and use struct rather than naked double to allow extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Adding another FIXME comment. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebPagePopupImpl.h ('k') | Source/web/WebPopupMenuImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebPagePopupImpl.cpp
diff --git a/Source/web/WebPagePopupImpl.cpp b/Source/web/WebPagePopupImpl.cpp
index e03b673c6b831fd25b73511e2f98aab0546c9905..648ba90dfc2b77f2652ff8bb741956325b378f63 100644
--- a/Source/web/WebPagePopupImpl.cpp
+++ b/Source/web/WebPagePopupImpl.cpp
@@ -280,8 +280,10 @@ WebSize WebPagePopupImpl::size()
return m_popupClient->contentSize();
}
-void WebPagePopupImpl::animate(double)
+void WebPagePopupImpl::beginFrame(const WebBeginFrameArgs& frameTime)
{
+ // FIXME: This should use frameTime.lastFrameTimeMonotonic but doing so
+ // breaks tests.
PageWidgetDelegate::animate(m_page.get(), monotonicallyIncreasingTime());
}
« no previous file with comments | « Source/web/WebPagePopupImpl.h ('k') | Source/web/WebPopupMenuImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698