Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: public/web/WebBeginFrameArgs.h

Issue 321373003: Changing animate to beginFrame and use struct rather than naked double to allow extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Reducing the surface area of this patch even further. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/web/WebBeginFrameArgs.h
diff --git a/public/platform/WebConnectionType.h b/public/web/WebBeginFrameArgs.h
similarity index 79%
copy from public/platform/WebConnectionType.h
copy to public/web/WebBeginFrameArgs.h
index 1b925fd863c565ed59550d8c4fda3897ee6d4964..24676a025c8dacebd3426e16ea46940b0328bb21 100644
--- a/public/platform/WebConnectionType.h
+++ b/public/web/WebBeginFrameArgs.h
@@ -28,23 +28,23 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef WebConnectionType_h
-#define WebConnectionType_h
+#ifndef WebBeginFrameArgs_h
+#define WebBeginFrameArgs_h
namespace blink {
-// Connection types from http://w3c.github.io/netinfo/.
-enum WebConnectionType {
- ConnectionTypeCellular = 0,
- ConnectionTypeBluetooth,
- ConnectionTypeEthernet,
- ConnectionTypeWifi,
- ConnectionTypeOther,
- ConnectionTypeNone,
- ConnectionTypeUnknown,
- ConnectionTypeLast = ConnectionTypeUnknown
+struct WebBeginFrameArgs {
+ WebBeginFrameArgs(double lastFrameTime)
+ : lastFrameTime(lastFrameTime)
+ { }
+
+ // FIXME(mithro): Upgrade the time in CLOCK_MONOTONIC values to use a
jamesr 2014/07/17 19:58:16 blink style is just FIXME, no name. If you want a
mithro-old 2014/07/18 00:21:05 Done.
+ // TimeTick like class rather than a bare double.
+
+ // Time in CLOCK_MONOTONIC that is the most recent vsync time.
+ double lastFrameTime;
nduca 2014/07/17 18:26:42 lastFrameTimeMonotonic
mithro-old 2014/07/18 00:21:04 Done.
};
} // namespace blink
-#endif // WebConnectionType_h
+#endif

Powered by Google App Engine
This is Rietveld 408576698