Source/web/WebViewImpl.cpp - Issue 321373003: Changing animate to beginFrame and use struct rather than naked double to allow extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.cpp

Issue 321373003: Changing animate to beginFrame and use struct rather than naked double to allow extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Reducing the surface area of this patch even further. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebViewImpl.cpp

diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp

index bcb4ac1e0ca3a636a7c01a796c221ed69ccdfba0..f0c58dedd0be81ca60a0ac6e257fc720676a8c68 100644

--- a/Source/web/WebViewImpl.cpp

+++ b/Source/web/WebViewImpl.cpp

@@ -119,6 +119,7 @@

#include "public/web/WebAXObject.h"

#include "public/web/WebActiveWheelFlingParameters.h"

#include "public/web/WebAutofillClient.h"

+#include "public/web/WebBeginFrameArgs.h"

#include "public/web/WebFrameClient.h"

#include "public/web/WebHitTestResult.h"

#include "public/web/WebInputElement.h"

@@ -1700,10 +1701,11 @@ void WebViewImpl::didExitFullScreen()

m_fullscreenController->didExitFullScreen();

}

-void WebViewImpl::animate(double monotonicFrameBeginTime)

+void WebViewImpl::beginFrame(const WebBeginFrameArgs& frameTime)

{

- TRACE_EVENT0("blink", "WebViewImpl::animate");

+ TRACE_EVENT0("blink", "WebViewImpl::beginFrame");

+ double monotonicFrameBeginTime = frameTime.lastFrameTime;

if (!monotonicFrameBeginTime)

monotonicFrameBeginTime = monotonicallyIncreasingTime();

« Source/web/WebPagePopupImpl.cpp ('K') | « Source/web/WebViewImpl.h ('k') | public/web/WebBeginFrameArgs.h » ('j') | public/web/WebBeginFrameArgs.h » ('J')