Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2563)

Unified Diff: Source/web/WebPagePopupImpl.cpp

Issue 321373003: Changing animate to beginFrame and use struct rather than naked double to allow extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Reducing the surface area of this patch even further. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebPagePopupImpl.cpp
diff --git a/Source/web/WebPagePopupImpl.cpp b/Source/web/WebPagePopupImpl.cpp
index e03b673c6b831fd25b73511e2f98aab0546c9905..f77a7f3808819714c6a2dc34746b02b01827c7b9 100644
--- a/Source/web/WebPagePopupImpl.cpp
+++ b/Source/web/WebPagePopupImpl.cpp
@@ -280,7 +280,7 @@ WebSize WebPagePopupImpl::size()
return m_popupClient->contentSize();
}
-void WebPagePopupImpl::animate(double)
+void WebPagePopupImpl::beginFrame(const WebBeginFrameArgs& frameTime)
{
PageWidgetDelegate::animate(m_page.get(), monotonicallyIncreasingTime());
jamesr 2014/07/17 19:58:16 do you have a particular reason to not use the par
mithro-old 2014/07/18 00:21:04 This method *should* use the passed in parameter.
jamesr 2014/07/18 00:30:15 Then leave a FIXME, ideally referencing the bug yo
}

Powered by Google App Engine
This is Rietveld 408576698