Changing animate to beginFrame and use struct rather than naked double to allow extension.

Source/web/WebPagePopupImpl.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 262 matching lines @@
             m_isAcceleratedCompositingActive = false;
         }
     }
 }
 
 WebSize WebPagePopupImpl::size()
 {
     return m_popupClient->contentSize();
 }
 
-void WebPagePopupImpl::animate(double)
+void WebPagePopupImpl::beginFrame(const WebBeginFrameArgs& frameTime)
 {
     PageWidgetDelegate::animate(m_page.get(), monotonicallyIncreasingTime());

[jamesr, 2014/07/17 19:58:16]

do you have a particular reason to not use the parameter for these types of
widgets?

[mithro-old, 2014/07/18 00:21:04]

This method *should* use the passed in parameter. 

Making it do so would make this patch have actually functional changes and sadly
it causes a bunch of tests to fail. (You can see it in previous patch sets.)

I've move that change into a separate patch which also fixes the tests.

[jamesr, 2014/07/18 00:30:15]

Then leave a FIXME, ideally referencing the bug you filed that described the
test failures so the next patch will have proper context

 }
 
 void WebPagePopupImpl::willCloseLayerTreeView()
 {
     setIsAcceleratedCompositingActive(false);
     m_layerTreeView = 0;
 }
 
 void WebPagePopupImpl::layout()
 {
@@ skipping 98 matching lines @@
     // A WebPagePopupImpl instance usually has two references.
     //  - One owned by the instance itself. It represents the visible widget.
     //  - One owned by a WebViewImpl. It's released when the WebViewImpl ask the
     //    WebPagePopupImpl to close.
     // We need them because the closing operation is asynchronous and the widget
     // can be closed while the WebViewImpl is unaware of it.
     return adoptRef(new WebPagePopupImpl(client)).leakRef();
 }
 
 } // namespace blink