Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 321373002: Update Lithium AddI, SubI, MulI, BitI, ShiftI, MathMinMax to support x32 port. (Closed)

Created:
6 years, 6 months ago by haitao.feng
Modified:
6 years, 6 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Update Lithium AddI, SubI, MulI, BitI, ShiftI, MathMinMax to support x32 port. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21827

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -21 lines) Patch
M src/x64/lithium-codegen-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 9 chunks +56 lines, -19 lines 0 comments Download
M src/x64/lithium-x64.cc View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
haitao.feng
This is the last big CL for the x32 port. Once https://codereview.chromium.org/324913002/ and this CL ...
6 years, 6 months ago (2014-06-11 04:00:10 UTC) #1
Toon Verwaest
lgtm
6 years, 6 months ago (2014-06-12 09:09:13 UTC) #2
haitao.feng
6 years, 6 months ago (2014-06-13 02:39:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21827.

Powered by Google App Engine
This is Rietveld 408576698