tools/telemetry/telemetry/page/actions/gesture_action.py - Issue 321253004: Kill wait_until support, which is unused once ClickElementAction is

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/actions/gesture_action.py

Issue 321253004: Kill wait_until support, which is unused once ClickElementAction is (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/page/actions/action_runner.py ('k') | tools/telemetry/telemetry/page/actions/javascript_click_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/page/actions/gesture_action.py

diff --git a/tools/telemetry/telemetry/page/actions/gesture_action.py b/tools/telemetry/telemetry/page/actions/gesture_action.py

index d05f6bab4633da7c3300deb68ae4ea7a429c0d22..14ba66381e91a97d7036d1491463bdbe9ff9374c 100644

--- a/tools/telemetry/telemetry/page/actions/gesture_action.py

+++ b/tools/telemetry/telemetry/page/actions/gesture_action.py

@@ -18,9 +18,6 @@ class GestureAction(page_action.PageAction):

else:

self.wait_action = None

- assert self.wait_until is None or self.wait_action is None, (

- 'gesture cannot have wait_after and wait_until at the same time.')

def RunAction(self, tab):

if self.wait_action:

interaction_name = 'Action_%s' % self.__class__.__name__