tools/telemetry/telemetry/page/actions/action_runner.py - Issue 321253004: Kill wait_until support, which is unused once ClickElementAction is

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/actions/action_runner.py

Issue 321253004: Kill wait_until support, which is unused once ClickElementAction is (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/actions/action_runner.py

diff --git a/tools/telemetry/telemetry/page/actions/action_runner.py b/tools/telemetry/telemetry/page/actions/action_runner.py

index e937c315e11761457337f6b1339c65802eacbc09..50f2999a175cc055e7fe1d147b9cd33c2578c036 100644

--- a/tools/telemetry/telemetry/page/actions/action_runner.py

+++ b/tools/telemetry/telemetry/page/actions/action_runner.py

@@ -18,9 +18,8 @@ class ActionRunner(object):

# TODO(nednguyen): remove this (or make private) when

# crbug.com/361809 is marked fixed

def RunAction(self, action):

- if not action.WillWaitAfterRun():

- action.WillRunAction(self._tab)

- action.RunActionAndMaybeWait(self._tab)

+ action.WillRunAction(self._tab)

+ action.RunAction(self._tab)

def BeginInteraction(self, label, is_smooth=False, is_responsive=False):

"""Marks the beginning of an interaction record.

« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/actions/gesture_action.py » ('j') | no next file with comments »