Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 321193002: cc: Test losing the output surface during deferred commits. (Closed)

Created:
6 years, 6 months ago by danakj
Modified:
6 years, 6 months ago
Reviewers:
brianderson, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, piman
Visibility:
Public.

Description

cc: Test losing the output surface during deferred commits. This adds a unit test that would fail after landing the https://codereview.chromium.org/287193003 CL without any further changes, documenting one regression it caused. R=brianderson, enne BUG=376649, 374287 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276428

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -0 lines) Patch
M cc/test/layer_tree_test.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/layer_tree_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 1 chunk +59 lines, -0 lines 3 comments Download

Messages

Total messages: 12 (0 generated)
danakj
6 years, 6 months ago (2014-06-10 16:37:29 UTC) #1
enne (OOO)
https://codereview.chromium.org/321193002/diff/1/cc/trees/layer_tree_host_unittest_context.cc File cc/trees/layer_tree_host_unittest_context.cc (right): https://codereview.chromium.org/321193002/diff/1/cc/trees/layer_tree_host_unittest_context.cc#newcode1508 cc/trees/layer_tree_host_unittest_context.cc:1508: MainThreadTaskRunner()->PostTask( This seems racy. Couldn't DeferCommitsOnMainThread(true), LoseContextOnImplThread, and DeferCommitsOnMainThread(false) ...
6 years, 6 months ago (2014-06-10 18:43:33 UTC) #2
danakj
https://codereview.chromium.org/321193002/diff/1/cc/trees/layer_tree_host_unittest_context.cc File cc/trees/layer_tree_host_unittest_context.cc (right): https://codereview.chromium.org/321193002/diff/1/cc/trees/layer_tree_host_unittest_context.cc#newcode1508 cc/trees/layer_tree_host_unittest_context.cc:1508: MainThreadTaskRunner()->PostTask( On 2014/06/10 18:43:32, enne wrote: > This seems ...
6 years, 6 months ago (2014-06-10 18:46:24 UTC) #3
enne (OOO)
lgtm https://codereview.chromium.org/321193002/diff/1/cc/trees/layer_tree_host_unittest_context.cc File cc/trees/layer_tree_host_unittest_context.cc (right): https://codereview.chromium.org/321193002/diff/1/cc/trees/layer_tree_host_unittest_context.cc#newcode1508 cc/trees/layer_tree_host_unittest_context.cc:1508: MainThreadTaskRunner()->PostTask( Oh, right. ScheduledActionWillSendBeginMainFrame is happening on the ...
6 years, 6 months ago (2014-06-10 18:59:43 UTC) #4
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 6 months ago (2014-06-10 18:59:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/321193002/1
6 years, 6 months ago (2014-06-10 19:02:31 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-10 23:53:09 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 11:54:33 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/19006)
6 years, 6 months ago (2014-06-11 11:54:34 UTC) #9
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 6 months ago (2014-06-11 14:14:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/321193002/1
6 years, 6 months ago (2014-06-11 14:15:32 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 16:30:40 UTC) #12
Message was sent while issue was closed.
Change committed as 276428

Powered by Google App Engine
This is Rietveld 408576698