cc: Stop blocking the main thread in CreateAndInitializeOutputSurface.

cc: Stop blocking the main thread in CreateAndInitializeOutputSurface.

The ThreadProxy does not need to block the main thread anymore, instead
have it post back DidInitializeOutputSurface() with the result of the
process.

We would delete all contents textures on the compositor thread during
OutputSurface creation, which doesn't really make sense, cuz the
ResourceProvider won't be the same one anymore, and this required
blocking the thread.

We also notified the main thread that the OutputSurface was lost when
creating the new output surface.

Instead, post a DidLoseOutputSurface() to the main thread to inform
the LayerTreeHost right away, and have that block and clean up
the contents textures immediately (to be removed when we always do
impl-side painting).

R=enne
BUG=374287
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272276

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276921

[danakj, 2014-05-16 20:09:16]

Depends on https://codereview.chromium.org/286293002/

[enne (OOO), 2014-05-16 22:37:29]

https://codereview.chromium.org/287193003/diff/60001/cc/trees/thread_proxy.cc
File cc/trees/thread_proxy.cc (right):

https://codereview.chromium.org/287193003/diff/60001/cc/trees/thread_proxy.cc...
cc/trees/thread_proxy.cc:248:
base::Bind(&ThreadProxy::CreateAndInitializeOutputSurface,
How is this not an infinite loop during failure?

CreateAndInitializeOutputSurface -> CreateOutputSurface returns NULL ->
DidInitializeOutputSurface(false, ...) ->
PostTask(...CreateAndInitializeOutputSurface...)

[danakj, 2014-05-16 22:45:29]

https://codereview.chromium.org/287193003/diff/60001/cc/trees/thread_proxy.cc
File cc/trees/thread_proxy.cc (right):

https://codereview.chromium.org/287193003/diff/60001/cc/trees/thread_proxy.cc...
cc/trees/thread_proxy.cc:248:
base::Bind(&ThreadProxy::CreateAndInitializeOutputSurface,
On 2014/05/16 22:37:29, enne wrote:
> How is this not an infinite loop during failure?
> 
> CreateAndInitializeOutputSurface -> CreateOutputSurface returns NULL ->
> DidInitializeOutputSurface(false, ...) ->
> PostTask(...CreateAndInitializeOutputSurface...)

After 5 failures, LayerTreeHost will LOG(FATAL) in
OnCreateAndInitializeOutputSurfaceAttempted.

[enne (OOO), 2014-05-16 22:46:31]

https://codereview.chromium.org/287193003/diff/60001/cc/trees/thread_proxy.cc
File cc/trees/thread_proxy.cc (right):

https://codereview.chromium.org/287193003/diff/60001/cc/trees/thread_proxy.cc...
cc/trees/thread_proxy.cc:248:
base::Bind(&ThreadProxy::CreateAndInitializeOutputSurface,
On 2014/05/16 22:45:29, danakj wrote:
> On 2014/05/16 22:37:29, enne wrote:
> > How is this not an infinite loop during failure?
> > 
> > CreateAndInitializeOutputSurface -> CreateOutputSurface returns NULL ->
> > DidInitializeOutputSurface(false, ...) ->
> > PostTask(...CreateAndInitializeOutputSurface...)
> 
> After 5 failures, LayerTreeHost will LOG(FATAL) in
> OnCreateAndInitializeOutputSurfaceAttempted.

And this will just keep posting tasks?

[danakj, 2014-05-16 22:48:40]

https://codereview.chromium.org/287193003/diff/60001/cc/trees/thread_proxy.cc
File cc/trees/thread_proxy.cc (right):

https://codereview.chromium.org/287193003/diff/60001/cc/trees/thread_proxy.cc...
cc/trees/thread_proxy.cc:248:
base::Bind(&ThreadProxy::CreateAndInitializeOutputSurface,
On 2014/05/16 22:46:31, enne wrote:
> On 2014/05/16 22:45:29, danakj wrote:
> > On 2014/05/16 22:37:29, enne wrote:
> > > How is this not an infinite loop during failure?
> > > 
> > > CreateAndInitializeOutputSurface -> CreateOutputSurface returns NULL ->
> > > DidInitializeOutputSurface(false, ...) ->
> > > PostTask(...CreateAndInitializeOutputSurface...)
> > 
> > After 5 failures, LayerTreeHost will LOG(FATAL) in
> > OnCreateAndInitializeOutputSurfaceAttempted.
> 
> And this will just keep posting tasks?

This calls OnCreateAndInitializeOutputSurfaceAttempted on line 243. The
LOG(FATAL) would crash so we'd stop. This should match our current behaviour
also, minus allowing the OutputSurface to be initailized mid-initialization by
CompositeAndReadback, at least this was my intent here.

[enne (OOO), 2014-05-19 21:42:54]

Ok.  I think I've wrapped my head around this.  lgtm

[danakj, 2014-05-20 21:56:53]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-05-20 21:57:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/287193003/60001

[commit-bot: I haz the power, 2014-05-21 07:27:12]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-21 09:31:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-21 09:31:15]

Try jobs failed on following builders:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[danakj, 2014-05-21 14:22:04]

The CQ bit was checked by danakj@chromium.org

[danakj, 2014-05-21 18:21:19]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2014-05-21 18:21:58]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-05-21 19:57:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/287193003/60001

[commit-bot: I haz the power, 2014-05-22 06:14:05]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-22 06:28:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 06:28:28]

Try jobs failed on following builders:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[danakj, 2014-05-22 15:22:15]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-05-22 15:23:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/287193003/60001

[commit-bot: I haz the power, 2014-05-22 15:31:10]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[danakj, 2014-05-22 15:38:15]

The CQ bit was unchecked by danakj@chromium.org

[commit-bot: I haz the power, 2014-05-22 15:39:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 15:39:48]

Try jobs failed on following builders:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[danakj, 2014-05-22 15:51:41]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-05-22 15:54:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/287193003/80001

[commit-bot: I haz the power, 2014-05-22 19:33:18]

Change committed as 272276

[danakj, 2014-05-23 19:45:17]

A revert of this CL has been created in
https://codereview.chromium.org/299233002/ by danakj@chromium.org.

The reason for reverting is: This may be causing mac browser test flakiness:
https://code.google.com/p/chromium/issues/detail?id=376649

.

[danakj, 2014-06-10 21:57:08]

I've fixed this CL to not blow up and try to do a BeginMainFrame when the output
surface is lost. I'm not sure if that resolves the resource_provider invalid
resource CHECK that was also occuring or not. I'm going to run some mac try bots
and see what they do.

[danakj, 2014-06-11 17:05:28]

Green trybots, going to try another run too. But please take a look at the
changes in the last patchset.

[enne (OOO), 2014-06-11 17:19:58]

On 2014/06/11 at 17:05:28, danakj wrote:
> Green trybots, going to try another run too. But please take a look at the
changes in the last patchset.

Seems legit. lgtm

[danakj, 2014-06-11 18:06:43]

I ran the DownloadExtensionTest.DownloadExtensionTest_Download_ConflictAction a
bunch of times on mac and it didnt fail there for me locally, so going to
reland.

[danakj, 2014-06-11 18:06:49]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-06-11 18:09:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/287193003/120001

[commit-bot: I haz the power, 2014-06-11 21:03:33]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-11 21:31:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 21:31:08]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[danakj, 2014-06-11 21:46:06]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-06-11 21:48:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/287193003/120001

[commit-bot: I haz the power, 2014-06-11 21:54:00]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-11 22:27:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 22:27:12]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[danakj, 2014-06-11 22:28:14]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-06-11 22:29:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/287193003/120001

[commit-bot: I haz the power, 2014-06-11 22:34:00]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-11 22:49:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 22:49:19]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[danakj, 2014-06-12 16:04:19]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-06-12 16:06:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/287193003/120001

[commit-bot: I haz the power, 2014-06-12 17:58:16]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-13 04:15:26]

Change committed as 276921