Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 321163005: adb_profile_chrome: Show interactive perf command (Closed)

Created:
6 years, 6 months ago by Sami
Modified:
6 years, 6 months ago
Reviewers:
Dominik Grewe
CC:
bulach+watch_chromium.org, chromium-reviews, ilevy-cc_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Visibility:
Public.

Description

adb_profile_chrome: Show interactive perf command Show interactive perf command in case the user wants to view the raw perf profile. BUG=375754 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276201

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M build/android/chrome_profiler/perf_controller.py View 3 chunks +23 lines, -1 line 1 comment Download

Messages

Total messages: 7 (0 generated)
Sami
6 years, 6 months ago (2014-06-10 15:31:28 UTC) #1
Dominik Grewe
https://codereview.chromium.org/321163005/diff/1/build/android/chrome_profiler/perf_controller.py File build/android/chrome_profiler/perf_controller.py (right): https://codereview.chromium.org/321163005/diff/1/build/android/chrome_profiler/perf_controller.py#newcode141 build/android/chrome_profiler/perf_controller.py:141: objdump_path = android_profiling_helper.GetToolchainBinaryPath( I can't find this method anywhere? ...
6 years, 6 months ago (2014-06-10 16:48:17 UTC) #2
Sami
On 2014/06/10 at 16:48:17, dominikg wrote: > https://codereview.chromium.org/321163005/diff/1/build/android/chrome_profiler/perf_controller.py > File build/android/chrome_profiler/perf_controller.py (right): > > https://codereview.chromium.org/321163005/diff/1/build/android/chrome_profiler/perf_controller.py#newcode141 ...
6 years, 6 months ago (2014-06-10 16:51:18 UTC) #3
Dominik Grewe
On 2014/06/10 16:51:18, Sami wrote: > On 2014/06/10 at 16:48:17, dominikg wrote: > > > ...
6 years, 6 months ago (2014-06-10 17:20:23 UTC) #4
Sami
The CQ bit was checked by skyostil@chromium.org
6 years, 6 months ago (2014-06-10 17:28:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/321163005/1
6 years, 6 months ago (2014-06-10 17:30:56 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 23:22:46 UTC) #7
Message was sent while issue was closed. 
Change committed as 276201

Powered by Google App Engine
This is Rietveld 408576698