adb_profile_chrome: Show interactive perf command

build/android/chrome_profiler/perf_controller.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 import os
 import subprocess
 import sys
 import tempfile
 
 from chrome_profiler import controllers
+from chrome_profiler import ui
 
 from pylib import android_commands
 from pylib import constants
 from pylib.perf import perf_control
 
 sys.path.append(os.path.join(constants.DIR_SOURCE_ROOT,
                              'tools',
                              'telemetry'))
 try:
   # pylint: disable=F0401
@@ skipping 99 matching lines @@
   def StartTracing(self, _):
     self._perf_instance = _PerfProfiler(self._device,
                                         self._perf_binary,
                                         self._categories)
 
   def StopTracing(self):
     if not self._perf_instance:
       return
     self._perf_instance.SignalAndWait()
 
+  @staticmethod
+  def _GetInteractivePerfCommand(perfhost_path, perf_profile, symfs_dir,
+                                 required_libs, kallsyms):
+    cmd = '%s report -n -i %s --symfs %s --kallsyms %s' % (
+        os.path.relpath(perfhost_path, '.'), perf_profile, symfs_dir, kallsyms)
+    for lib in required_libs:
+      lib = os.path.join(symfs_dir, lib[1:])
+      if not os.path.exists(lib):
+        continue
+      objdump_path = android_profiling_helper.GetToolchainBinaryPath(

[Dominik Grewe, 2014/06/10 16:48:17]

I can't find this method anywhere? Did you mean to add it with this patch?

+          lib, 'objdump')
+      if objdump_path:
+        cmd += ' --objdump %s' % os.path.relpath(objdump_path, '.')
+        break
+    return cmd
+
   def PullTrace(self):
     symfs_dir = os.path.join(tempfile.gettempdir(),
                              os.path.expandvars('$USER-perf-symfs'))
     if not os.path.exists(symfs_dir):
       os.makedirs(symfs_dir)
     required_libs = set()
 
     # Download the recorded perf profile.
     perf_profile = self._perf_instance.PullResult(symfs_dir)
     required_libs = \
         android_profiling_helper.GetRequiredLibrariesForPerfProfile(
             perf_profile)
     if not required_libs:
       logging.warning('No libraries required by perf trace. Most likely there '
                       'are no samples in the trace.')
 
     # Build a symfs with all the necessary libraries.
     kallsyms = android_profiling_helper.CreateSymFs(self._device,
                                                     symfs_dir,
                                                     required_libs,
                                                     use_symlinks=False)
-    # Convert the perf profile into JSON.
     perfhost_path = os.path.abspath(support_binaries.FindPath(
         'perfhost', 'linux'))
+
+    ui.PrintMessage('\nNote: to view the profile in perf, run:')
+    ui.PrintMessage('  ' + self._GetInteractivePerfCommand(perfhost_path,
+        perf_profile, symfs_dir, required_libs, kallsyms))
+
+    # Convert the perf profile into JSON.
     perf_script_path = os.path.join(constants.DIR_SOURCE_ROOT,
         'tools', 'telemetry', 'telemetry', 'core', 'platform', 'profiler',
         'perf_vis', 'perf_to_tracing.py')
     json_file_name = os.path.basename(perf_profile)
     with open(os.devnull, 'w') as dev_null, \
         open(json_file_name, 'w') as json_file:
       cmd = [perfhost_path, 'script', '-s', perf_script_path, '-i',
              perf_profile, '--symfs', symfs_dir, '--kallsyms', kallsyms]
       subprocess.call(cmd, stdout=json_file, stderr=dev_null)
     return json_file_name