Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 321003002: Fix bug in QuicStreamFactory where the initial congestion window (Closed)

Created:
6 years, 6 months ago by Ryan Hamilton
Modified:
6 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Fix bug in QuicStreamFactory where the initial congestion window was set on the wrong QuicConfig object. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276053

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/quic/quic_stream_factory.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Ryan Hamilton
This fixes a bug I didn't catch in the review of https://codereview.chromium.org/291623003 which rjshade noticed ...
6 years, 6 months ago (2014-06-09 19:15:38 UTC) #1
jar (doing other things)
lgtm
6 years, 6 months ago (2014-06-09 20:03:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/321003002/1
6 years, 6 months ago (2014-06-09 20:05:22 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-10 09:00:26 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-10 12:22:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/161018)
6 years, 6 months ago (2014-06-10 12:22:50 UTC) #6
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 6 months ago (2014-06-10 16:34:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/321003002/1
6 years, 6 months ago (2014-06-10 16:36:44 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 16:39:21 UTC) #9
Message was sent while issue was closed. 
Change committed as 276053

Powered by Google App Engine
This is Rietveld 408576698