Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 291623003: Increase QUIC's proposed server Intial CWND to 32 for HTTPS to 30; HTTP to 20 (Closed)

Created:
6 years, 7 months ago by jar (doing other things)
Modified:
6 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Increase QUIC's proposed server Intial CWND to 32 for HTTPS to 30; HTTP to 20 r=rch BUG=374331 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271286

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M net/quic/quic_stream_factory.cc View 1 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jar (doing other things)
PTAL
6 years, 7 months ago (2014-05-16 19:50:47 UTC) #1
Ryan Hamilton
LGTM, I think. One question. https://codereview.chromium.org/291623003/diff/1/net/quic/quic_stream_factory.cc File net/quic/quic_stream_factory.cc (right): https://codereview.chromium.org/291623003/diff/1/net/quic/quic_stream_factory.cc#newcode760 net/quic/quic_stream_factory.cc:760: if (server_id.is_https()) It this ...
6 years, 7 months ago (2014-05-16 19:53:37 UTC) #2
jar (doing other things)
https://chromiumcodereview.appspot.com/291623003/diff/1/net/quic/quic_stream_factory.cc File net/quic/quic_stream_factory.cc (right): https://chromiumcodereview.appspot.com/291623003/diff/1/net/quic/quic_stream_factory.cc#newcode760 net/quic/quic_stream_factory.cc:760: if (server_id.is_https()) On 2014/05/16 19:53:38, Ryan Hamilton wrote: > ...
6 years, 7 months ago (2014-05-16 21:03:21 UTC) #3
jar (doing other things)
The CQ bit was checked by jar@chromium.org
6 years, 7 months ago (2014-05-16 21:27:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jar@chromium.org/291623003/20001
6 years, 7 months ago (2014-05-16 23:34:16 UTC) #5
jar (doing other things)
The CQ bit was checked by jar@chromium.org
6 years, 7 months ago (2014-05-18 08:08:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jar@chromium.org/291623003/20001
6 years, 7 months ago (2014-05-18 08:09:20 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-18 14:01:59 UTC) #8
Message was sent while issue was closed.
Change committed as 271286

Powered by Google App Engine
This is Rietveld 408576698