DevTools: Expand protocol to allow setting DOM event breakpoints on a given event target.

DevTools: Expand protocol to allow setting DOM event breakpoints on a given event target.

This will allow debugger to pause on "load", "error" and etc. event breakpoints only
when they happen on XHR event targets.

BUG=381470
R=yurys, pfeldman@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175882

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175964

[yurys, 2014-06-10 08:49:53]

lgtm

https://codereview.chromium.org/320933003/diff/20001/Source/core/inspector/In...
File Source/core/inspector/InspectorDOMDebuggerAgent.cpp (right):

https://codereview.chromium.org/320933003/diff/20001/Source/core/inspector/In...
Source/core/inspector/InspectorDOMDebuggerAgent.cpp:214:
breakpointsByTarget->remove(DOMDebuggerAgentState::eventTargetAny);
It might make sense to remove all targets if targetName is not specified.

[aandrey, 2014-06-10 09:14:38]

https://codereview.chromium.org/320933003/diff/20001/Source/core/inspector/In...
File Source/core/inspector/InspectorDOMDebuggerAgent.cpp (right):

https://codereview.chromium.org/320933003/diff/20001/Source/core/inspector/In...
Source/core/inspector/InspectorDOMDebuggerAgent.cpp:214:
breakpointsByTarget->remove(DOMDebuggerAgentState::eventTargetAny);
On 2014/06/10 08:49:53, yurys wrote:
> It might make sense to remove all targets if targetName is not specified. 

I dont think so.
e.g. if we have an option to break on "load" event on all targets, and on "load"
only for XHRs.
Removing the former option (a checkbox in the UI) should not affect the latter.

[aandrey, 2014-06-10 09:14:42]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-06-10 09:15:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aandrey@chromium.org/320933003/20001

[commit-bot: I haz the power, 2014-06-10 09:15:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-10 09:15:26]

Failed to apply patch for
LayoutTests/inspector/sources/debugger/event-listener-breakpoints-expected.txt:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
LayoutTests/inspector/sources/debugger/event-listener-breakpoints-expected.txt
  Hunk #1 succeeded at 8 (offset -1 lines).
  Hunk #2 FAILED at 17.
  1 out of 2 hunks FAILED -- saving rejects to file
LayoutTests/inspector/sources/debugger/event-listener-breakpoints-expected.txt.rej

Patch:      
LayoutTests/inspector/sources/debugger/event-listener-breakpoints-expected.txt
Index:
LayoutTests/inspector/sources/debugger/event-listener-breakpoints-expected.txt
diff --git
a/LayoutTests/inspector/sources/debugger/event-listener-breakpoints-expected.txt
b/LayoutTests/inspector/sources/debugger/event-listener-breakpoints-expected.txt
index
3e1a7bb7aa2b96eadd44ce7e1a97e937ee105783..6e35827509dd914216bd994bc4ae6dc890a3380d
100644
---
a/LayoutTests/inspector/sources/debugger/event-listener-breakpoints-expected.txt
+++
b/LayoutTests/inspector/sources/debugger/event-listener-breakpoints-expected.txt
@@ -9,6 +9,7 @@ Call stack:
     0) testElementClicked (event-listener-breakpoints.html:7)
     1) addListenerAndClick (event-listener-breakpoints.html:16)
     2)  (:1)
+Event target: Node
 Script execution resumed.
 
 Running: testTimerFiredBreakpoint
@@ -16,5 +17,12 @@ Script execution paused.
 Call stack:
     0) timerFired (event-listener-breakpoints.html:19)
 Script execution resumed.
+
+Running: testLoadBreakpointOnXHR
+Script execution paused.
+Call stack:
+    0) loadCallback (event-listener-breakpoints.html:42)
+Event target: XMLHttpRequest
+Script execution resumed.
 Debugger was disabled.

[aandrey, 2014-06-10 09:48:20]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-06-10 09:49:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aandrey@chromium.org/320933003/40001

[commit-bot: I haz the power, 2014-06-10 10:58:35]

Change committed as 175882

[dcheng, 2014-06-10 18:28:47]

A revert of this CL has been created in
https://codereview.chromium.org/322893006/ by dcheng@chromium.org.

The reason for reverting is: event-listener-breakpoints.html always timing out
on Mac 10.6 (dbg):
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20(dbg).

[aandrey, 2014-06-11 12:41:28]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-06-11 12:41:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aandrey@chromium.org/320933003/60001

[commit-bot: I haz the power, 2014-06-11 13:44:48]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/11574)
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-06-11 13:44:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 13:44:59]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[aandrey, 2014-06-11 15:00:19]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-06-11 15:01:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aandrey@chromium.org/320933003/60001

[commit-bot: I haz the power, 2014-06-11 15:01:25]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-06-11 15:01:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 15:01:36]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[aandrey, 2014-06-11 16:13:14]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-06-11 16:14:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aandrey@chromium.org/320933003/60001

[commit-bot: I haz the power, 2014-06-11 16:14:52]

Change committed as 175964