Source/core/inspector/InspectorDOMDebuggerAgent.h - Issue 320933003: DevTools: Expand protocol to allow setting DOM event breakpoints on a given event target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorDOMDebuggerAgent.h

Issue 320933003: DevTools: Expand protocol to allow setting DOM event breakpoints on a given event target. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: skip test on mac 10.6 dbg Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector/sources/debugger/event-listener-breakpoints-expected.txt ('k') | Source/core/inspector/InspectorDOMDebuggerAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InspectorDOMDebuggerAgent.h

diff --git a/Source/core/inspector/InspectorDOMDebuggerAgent.h b/Source/core/inspector/InspectorDOMDebuggerAgent.h

index fe2ee7cbc05223667b4217cdc023898c605247b5..c6693b2e783eb3f78ec32bcc8143154ea359cc9b 100644

--- a/Source/core/inspector/InspectorDOMDebuggerAgent.h

+++ b/Source/core/inspector/InspectorDOMDebuggerAgent.h

@@ -68,8 +68,8 @@ public:

// DOMDebugger API for InspectorFrontend

virtual void setXHRBreakpoint(ErrorString*, const String& url) OVERRIDE;

virtual void removeXHRBreakpoint(ErrorString*, const String& url) OVERRIDE;

- virtual void setEventListenerBreakpoint(ErrorString*, const String& eventName) OVERRIDE;

- virtual void removeEventListenerBreakpoint(ErrorString*, const String& eventName) OVERRIDE;

+ virtual void setEventListenerBreakpoint(ErrorString*, const String& eventName, const String* targetName) OVERRIDE;

+ virtual void removeEventListenerBreakpoint(ErrorString*, const String& eventName, const String* targetName) OVERRIDE;

virtual void setInstrumentationBreakpoint(ErrorString*, const String& eventName) OVERRIDE;

virtual void removeInstrumentationBreakpoint(ErrorString*, const String& eventName) OVERRIDE;

virtual void setDOMBreakpoint(ErrorString*, int nodeId, const String& type) OVERRIDE;

@@ -104,7 +104,7 @@ private:

InspectorDOMDebuggerAgent(InspectorDOMAgent*, InspectorDebuggerAgent*);

void pauseOnNativeEventIfNeeded(PassRefPtr<JSONObject> eventData, bool synchronous);

- PassRefPtr<JSONObject> preparePauseOnNativeEventData(bool isDOMEvent, const String& eventName);

+ PassRefPtr<JSONObject> preparePauseOnNativeEventData(const String& eventName, const AtomicString* targetName);

// InspectorDOMAgent::Listener implementation.

virtual void domAgentWasEnabled() OVERRIDE;

@@ -120,8 +120,8 @@ private:

void descriptionForDOMEvent(Node* target, int breakpointType, bool insertion, JSONObject* description);

void updateSubtreeBreakpoints(Node*, uint32_t rootMask, bool set);

bool hasBreakpoint(Node*, int type);

- void setBreakpoint(ErrorString*, const String& eventName);

- void removeBreakpoint(ErrorString*, const String& eventName);

+ void setBreakpoint(ErrorString*, const String& eventName, const String* targetName);

+ void removeBreakpoint(ErrorString*, const String& eventName, const String* targetName);

void clear();