Issue 32093003: [GCM] Unrevert initial GCM patch

Issue 32093003: [GCM] Unrevert initial GCM patch (Closed)

Created:
7 years, 2 months ago by Nicolas Zea

Modified:
7 years, 2 months ago

Reviewers:
darin (slow to review), akalin

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[GCM] Unrevert initial GCM patch Includes build fix for static libraries and ensure that gcm_unit_tests is run on relevant builders. Original codereview: https://codereview.chromium.org/23684017/ BUG=284553 TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229982

Patch Set 1 #

Patch Set 2 : Set upstream #

Patch Set 3 : Fix build rules and ensure buildbots run tests #

Patch Set 4 : Revert gcm_export change #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1054 lines, -10 lines)			Patch
M	build/all.gyp	View	1 2	7 chunks	+15 lines, -0 lines	0 comments	Download
A +	google_apis/gcm/DEPS	View		1 chunk	+3 lines, -5 lines	0 comments	Download
A	google_apis/gcm/OWNERS	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	google_apis/gcm/base/gcm_export.h	View	3	1 chunk	+29 lines, -0 lines	0 comments	Download
A	google_apis/gcm/base/socket_stream.h	View		1 chunk	+205 lines, -0 lines	0 comments	Download
A	google_apis/gcm/base/socket_stream.cc	View		1 chunk	+332 lines, -0 lines	0 comments	Download
A	google_apis/gcm/base/socket_stream_unittest.cc	View		1 chunk	+406 lines, -0 lines	0 comments	Download
A	google_apis/gcm/gcm.gyp	View	1 2	1 chunk	+56 lines, -0 lines	0 comments	Download
M	net/socket/socket_test_util.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	net/socket/socket_test_util.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Nicolas Zea

Fred, please take a look. The last patchset contains the changes from the original patch ...

7 years, 2 months ago (2013-10-21 20:10:09 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/32093003/390001

7 years, 2 months ago (2013-10-21 21:43:28 UTC) #3

commit-bot: I haz the power

Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=31660

7 years, 2 months ago (2013-10-21 22:07:26 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/32093003/390001

7 years, 2 months ago (2013-10-21 22:15:41 UTC) #6

Message was sent while issue was closed.

Change committed as 229982

Expand Messages | Collapse Messages