content/child/indexed_db/webidbdatabase_impl.h - Issue 320833002: [IndexedDB] Use consistent enums on both sides of IPC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/indexed_db/webidbdatabase_impl.h

Issue 320833002: [IndexedDB] Use consistent enums on both sides of IPC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated review comments. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/indexed_db/indexed_db_dispatcher_host.cc ('K') | « content/child/indexed_db/indexed_db_dispatcher_unittest.cc ('k') | content/child/indexed_db/webidbdatabase_impl.cc » ('j') | content/common/indexed_db/indexed_db_messages.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/indexed_db/webidbdatabase_impl.h

diff --git a/content/child/indexed_db/webidbdatabase_impl.h b/content/child/indexed_db/webidbdatabase_impl.h

index 088f722be5ad9de04595a3eb8621d6b272d6f10c..f1f43c884fdbc6514c2fb4dd20af178bdc91e26b 100644

--- a/content/child/indexed_db/webidbdatabase_impl.h

+++ b/content/child/indexed_db/webidbdatabase_impl.h

@@ -9,6 +9,7 @@

#include "base/memory/ref_counted.h"

#include "third_party/WebKit/public/platform/WebIDBCursor.h"

#include "third_party/WebKit/public/platform/WebIDBDatabase.h"

+#include "third_party/WebKit/public/platform/WebIDBTypes.h"

namespace blink {

class WebBlobInfo;

@@ -38,7 +39,7 @@ class WebIDBDatabaseImpl : public blink::WebIDBDatabase {

virtual void createTransaction(long long transaction_id,

blink::WebIDBDatabaseCallbacks* callbacks,

const blink::WebVector<long long>& scope,

- blink::WebIDBDatabase::TransactionMode mode);

+ blink::WebIDBTransactionMode mode);

virtual void close();

virtual void get(long long transactionId,

long long objectStoreId,

@@ -52,7 +53,7 @@ class WebIDBDatabaseImpl : public blink::WebIDBDatabase {

long long objectStoreId,

const blink::WebData& value,

const blink::WebIDBKey&,

- PutMode,

+ blink::WebIDBPutMode,

blink::WebIDBCallbacks*,

const blink::WebVector<long long>& indexIds,

const blink::WebVector<WebIndexKeys>&);

@@ -61,7 +62,7 @@ class WebIDBDatabaseImpl : public blink::WebIDBDatabase {

const blink::WebData& value,

const blink::WebVector<blink::WebBlobInfo>& webBlobInfo,

const blink::WebIDBKey&,

- PutMode,

+ blink::WebIDBPutMode,

blink::WebIDBCallbacks*,

const blink::WebVector<long long>& indexIds,

const blink::WebVector<WebIndexKeys>&);

@@ -77,9 +78,9 @@ class WebIDBDatabaseImpl : public blink::WebIDBDatabase {

long long objectStoreId,

long long indexId,

const blink::WebIDBKeyRange&,

- blink::WebIDBCursor::Direction direction,

+ blink::WebIDBCursorDirection direction,

bool keyOnly,

- TaskType,

+ blink::WebIDBTaskType,

blink::WebIDBCallbacks*);

virtual void count(long long transactionId,

long long objectStoreId,