content/child/indexed_db/webidbdatabase_impl.cc - Issue 320833002: [IndexedDB] Use consistent enums on both sides of IPC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/indexed_db/webidbdatabase_impl.cc

Issue 320833002: [IndexedDB] Use consistent enums on both sides of IPC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated review comments. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/indexed_db/indexed_db_dispatcher_host.cc ('K') | « content/child/indexed_db/webidbdatabase_impl.h ('k') | content/common/indexed_db/indexed_db_messages.h » ('j') | content/common/indexed_db/indexed_db_messages.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/indexed_db/webidbdatabase_impl.cc

diff --git a/content/child/indexed_db/webidbdatabase_impl.cc b/content/child/indexed_db/webidbdatabase_impl.cc

index ee83e187a5b98772a5fe4859fb9658ea723df6c9..8179ca2a4cc5d2178a438ba7467ee1ef10cc5f19 100644

--- a/content/child/indexed_db/webidbdatabase_impl.cc

+++ b/content/child/indexed_db/webidbdatabase_impl.cc

@@ -77,7 +77,7 @@ void WebIDBDatabaseImpl::createTransaction(

long long transaction_id,

WebIDBDatabaseCallbacks* callbacks,

const WebVector<long long>& object_store_ids,

- WebIDBDatabase::TransactionMode mode) {

+ blink::WebIDBTransactionMode mode) {

IndexedDBDispatcher* dispatcher =

IndexedDBDispatcher::ThreadSpecificInstance(thread_safe_sender_.get());

dispatcher->RequestIDBDatabaseCreateTransaction(

@@ -114,7 +114,7 @@ void WebIDBDatabaseImpl::put(long long transaction_id,

long long object_store_id,

const blink::WebData& value,

const WebIDBKey& key,

- PutMode put_mode,

+ blink::WebIDBPutMode put_mode,

WebIDBCallbacks* callbacks,

const WebVector<long long>& web_index_ids,

const WebVector<WebIndexKeys>& web_index_keys) {

@@ -138,7 +138,7 @@ void WebIDBDatabaseImpl::put(long long transaction_id,

const blink::WebData& value,

const blink::WebVector<WebBlobInfo>& web_blob_info,

const WebIDBKey& key,

- PutMode put_mode,

+ blink::WebIDBPutMode put_mode,

WebIDBCallbacks* callbacks,

const WebVector<long long>& web_index_ids,

const WebVector<WebIndexKeys>& web_index_keys) {

@@ -196,9 +196,9 @@ void WebIDBDatabaseImpl::openCursor(long long transaction_id,

long long object_store_id,

long long index_id,

const WebIDBKeyRange& key_range,

- WebIDBCursor::Direction direction,

+ blink::WebIDBCursorDirection direction,

bool key_only,

- TaskType task_type,

+ blink::WebIDBTaskType task_type,

WebIDBCallbacks* callbacks) {

IndexedDBDispatcher* dispatcher =

IndexedDBDispatcher::ThreadSpecificInstance(thread_safe_sender_.get());