Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 320733002: Revert of Clean up Test's resourcePath code. (Closed)

Created:
6 years, 6 months ago by mtklein
Modified:
6 years, 6 months ago
Reviewers:
tfarina
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Clean up Test's resourcePath code. (https://codereview.chromium.org/319473003/) Reason for revert: Some benchmarks are written in a way that makes this change unsafe (e.g. const char* resPath = GetResourcePath().c_str(); in SkipZeroesBench) and Valgrind and ASAN caught that. We can try again after a more careful cleanup of GetResourcePath(). Original issue's description: > Clean up resourcePath code. > > 1) Make the implementation of SetResourcePath/GetResourcePath of GM and SkBenchmark match with the one in Test. > 2) Make gResourcePath a static pointer to const char and move it inside the classes. > > BUG=None > TEST=make tests && out/Debug/tests > make gm && out/Debug/gm > make bench && out/Debug/bench > R=mtklein@google.com > > Committed: https://skia.googlesource.com/skia/+/52e4f413ffe2d281f9e90ff2147db08083ffcba7 TBR=tfarina@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Committed: https://skia.googlesource.com/skia/+/91359bed48bc006a4319da86eb26db3b2e6d4afb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -37 lines) Patch
M bench/SkBenchmark.h View 2 chunks +4 lines, -3 lines 0 comments Download
M bench/SkBenchmark.cpp View 2 chunks +1 line, -8 lines 0 comments Download
M gm/copyTo4444.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M gm/etc1bitmap.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M gm/factory.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M gm/gm.h View 2 chunks +8 lines, -3 lines 0 comments Download
M gm/gm.cpp View 3 chunks +1 line, -11 lines 0 comments Download
M tests/Test.h View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/Test.cpp View 3 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of Clean up Test's resourcePath code.
6 years, 6 months ago (2014-06-08 14:02:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/320733002/1
6 years, 6 months ago (2014-06-08 14:02:41 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-08 14:02:51 UTC) #3
Message was sent while issue was closed.
Change committed as 91359bed48bc006a4319da86eb26db3b2e6d4afb

Powered by Google App Engine
This is Rietveld 408576698