Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 320713002: Revert of Omnibox: Combine Two Input Type Enums into One (Closed)

Created:
6 years, 6 months ago by dcheng
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, extensions-reviews_chromium.org, tfarina, jar+watch_chromium.org, asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org, James Su, Ilya Sherman
Visibility:
Public.

Description

Revert of Omnibox: Combine Two Input Type Enums into One (https://codereview.chromium.org/319523005/) Reason for revert: Broke the build on http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac Original issue's description: > Omnibox: Combine Two Input Type Enums into One > > There are two input type enums: > * one in the autocomplete code > * one in the metrics code that's used for UMA logging; > this one is meant to remain stable > > As part of fixing the linked bug, I created > https://codereview.chromium.org/314773002/ > whch needed an input type enum, one which would remain stable. > It didn't necessarily have to be the metrics enum. > > After discussion with the UMA folks (who deal with how to handle > stable enum problems all the time), we reached the conclusion > that we should have one stable enum and use it everywhere. That's > the cleanest answer. > > This single enum has to live in the metrics directory because metrics > is a component. > > This change combines the two existing enums into one, putting the > new enum in a new file in the metrics directory. The reason for > a new file is so we can include it without include the whole > OmniboxEventProto or any other metrics code. > > The main files to review are autocomplete_input.h and *.proto. > All other changes are a mechanical result of the changes in > those three files. > > The internal proto change has been submitted. > > TBR=stevenjb > for the trivial change to chrome/browser/ui/app_list/search/omnibox_provider.cc > that removes an unnecessary include > > BUG=284781 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275696 TBR=pkasting@chromium.org,isherman@chromium.org,mpearson@chromium.org NOTREECHECKS=true NOTRY=true BUG=284781 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275706

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -304 lines) Patch
M chrome/browser/autocomplete/autocomplete_input.h View 1 chunk +11 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_input.cc View 18 chunks +46 lines, -54 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_input_unittest.cc View 3 chunks +109 lines, -118 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_result.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/autocomplete/base_search_provider.cc View 4 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/autocomplete/bookmark_provider.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/autocomplete/builtin_provider.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/extension_app_provider.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/autocomplete/extension_app_provider.cc View 4 chunks +8 lines, -10 lines 0 comments Download
M chrome/browser/autocomplete/history_quick_provider.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider.cc View 7 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider_unittest.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/browser/autocomplete/keyword_provider.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/autocomplete/keyword_provider.cc View 4 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/autocomplete/search_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/search_provider.cc View 11 chunks +13 lines, -15 lines 0 comments Download
M chrome/browser/autocomplete/shortcuts_provider.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/zero_suggest_provider.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/metrics/omnibox_metrics_provider.cc View 2 chunks +19 lines, -3 lines 0 comments Download
M chrome/browser/omnibox/omnibox_log.h View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/omnibox/omnibox_log.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/omnibox_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/metrics.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/metrics/proto/omnibox_event.proto View 2 chunks +12 lines, -3 lines 0 comments Download
D components/metrics/proto/omnibox_input_type.proto View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcheng
Created Revert of Omnibox: Combine Two Input Type Enums into One
6 years, 6 months ago (2014-06-07 23:17:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/320713002/1
6 years, 6 months ago (2014-06-07 23:18:27 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 23:19:17 UTC) #3
Message was sent while issue was closed.
Change committed as 275706

Powered by Google App Engine
This is Rietveld 408576698