Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: components/metrics/proto/omnibox_event.proto

Issue 320713002: Revert of Omnibox: Combine Two Input Type Enums into One (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « components/metrics.gypi ('k') | components/metrics/proto/omnibox_input_type.proto » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Stores information about an omnibox interaction. 5 // Stores information about an omnibox interaction.
6 6
7 syntax = "proto2"; 7 syntax = "proto2";
8 8
9 option optimize_for = LITE_RUNTIME; 9 option optimize_for = LITE_RUNTIME;
10 10
11 package metrics; 11 package metrics;
12 12
13 import "omnibox_input_type.proto";
14
15 // Next tag: 17 13 // Next tag: 17
16 message OmniboxEventProto { 14 message OmniboxEventProto {
17 // The timestamp for the event, in seconds since the epoch. 15 // The timestamp for the event, in seconds since the epoch.
18 optional int64 time = 1; 16 optional int64 time = 1;
19 17
20 // The id of the originating tab for this omnibox interaction. 18 // The id of the originating tab for this omnibox interaction.
21 // This is the current tab *unless* the user opened the target in a new tab. 19 // This is the current tab *unless* the user opened the target in a new tab.
22 // In those cases, this is unset. Tab ids are unique for a given session_id 20 // In those cases, this is unset. Tab ids are unique for a given session_id
23 // (in the containing protocol buffer ChromeUserMetricsExtensionProto). 21 // (in the containing protocol buffer ChromeUserMetricsExtensionProto).
24 optional int32 tab_id = 2; 22 optional int32 tab_id = 2;
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 // replacement, meaning the URL of the page should've appeared in the 123 // replacement, meaning the URL of the page should've appeared in the
126 // omnibox before the user started editing it, not the search terms. 124 // omnibox before the user started editing it, not the search terms.
127 SEARCH_RESULT_PAGE_NO_SEARCH_TERM_REPLACEMENT = 9; 125 SEARCH_RESULT_PAGE_NO_SEARCH_TERM_REPLACEMENT = 9;
128 126
129 // When adding new classifications, please consider adding them in 127 // When adding new classifications, please consider adding them in
130 // chrome/browser/resources/omnibox/omnibox.html 128 // chrome/browser/resources/omnibox/omnibox.html
131 // so that these new options are displayed on about:omnibox. 129 // so that these new options are displayed on about:omnibox.
132 } 130 }
133 optional PageClassification current_page_classification = 10; 131 optional PageClassification current_page_classification = 10;
134 132
135 optional OmniboxInputType.Type input_type = 8; 133 // What kind of input the user provided.
134 enum InputType {
135 INVALID = 0; // Empty input (should not reach here)
136 UNKNOWN = 1; // Valid input whose type cannot be determined
137 REQUESTED_URL = 2; // DEPRECATED. Input autodetected as UNKNOWN, which the
138 // user wants to treat as an URL by specifying a
139 // desired_tld
140 URL = 3; // Input autodetected as a URL
141 QUERY = 4; // Input autodetected as a query
142 FORCED_QUERY = 5; // Input forced to be a query by an initial '?'
143 }
144 optional InputType input_type = 8;
136 145
137 // An enum used in multiple places below. 146 // An enum used in multiple places below.
138 enum ProviderType { 147 enum ProviderType {
139 UNKNOWN_PROVIDER = 0; // Unknown provider (should not reach here) 148 UNKNOWN_PROVIDER = 0; // Unknown provider (should not reach here)
140 HISTORY_URL = 1; // URLs in history, or user-typed URLs 149 HISTORY_URL = 1; // URLs in history, or user-typed URLs
141 HISTORY_CONTENTS = 2; // Matches for page contents of pages in history 150 HISTORY_CONTENTS = 2; // Matches for page contents of pages in history
142 HISTORY_QUICK = 3; // Matches for recently or frequently visited pages 151 HISTORY_QUICK = 3; // Matches for recently or frequently visited pages
143 // in history 152 // in history
144 SEARCH = 4; // Search suggestions for the default search engine 153 SEARCH = 4; // Search suggestions for the default search engine
145 KEYWORD = 5; // Keyword-triggered searches 154 KEYWORD = 5; // Keyword-triggered searches
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
252 // The number of times this provider returned a non-zero number of 261 // The number of times this provider returned a non-zero number of
253 // suggestions during this omnibox session. 262 // suggestions during this omnibox session.
254 // Note that each provider may define a session differently for its 263 // Note that each provider may define a session differently for its
255 // purposes. 264 // purposes.
256 optional int32 times_returned_results_in_session = 5; 265 optional int32 times_returned_results_in_session = 5;
257 } 266 }
258 // A list of diagnostic information about each provider. Providers 267 // A list of diagnostic information about each provider. Providers
259 // will appear at most once in this list. 268 // will appear at most once in this list.
260 repeated ProviderInfo provider_info = 12; 269 repeated ProviderInfo provider_info = 12;
261 } 270 }
OLDNEW
« no previous file with comments | « components/metrics.gypi ('k') | components/metrics/proto/omnibox_input_type.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698