Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 320523003: Use same vk non-overscroll solution for both login and lock screens (Closed)

Created:
6 years, 6 months ago by Nikita (slow)
Modified:
6 years, 6 months ago
CC:
chromium-reviews, arv+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Use same vk non-overscroll solution for both login and lock screens Depends on https://codereview.chromium.org/254673004/ which introduces new layout manager for LockScreenContainer. This means that lock screen UI now supports resizing when virtual keyboard is shown and overscroll is disabled. Custom code for lock screen that "scrolled" user pods into view is not needed anymore, reusing login UI solution (http://crbug.com/363635). This CL partially reverts https://codereview.chromium.org/304153004 To disable lock screen scroll into view use same --disable-login-scroll-into-view BUG=375666 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275800

Patch Set 1 #

Patch Set 2 : cl #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -46 lines) Patch
M chrome/browser/chromeos/login/helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/helper.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/lock/webui_screen_locker.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/login/display_manager.js View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/resources/login/screen_container.css View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc View 1 1 chunk +8 lines, -18 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Nikita (slow)
6 years, 6 months ago (2014-06-06 08:54:44 UTC) #1
Nikita (slow)
PTAL
6 years, 6 months ago (2014-06-06 19:13:06 UTC) #2
dzhioev (left Google)
On 2014/06/06 19:13:06, Nikita Kostylev wrote: > PTAL LGTM
6 years, 6 months ago (2014-06-09 08:22:41 UTC) #3
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 6 months ago (2014-06-09 08:29:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/320523003/40001
6 years, 6 months ago (2014-06-09 08:29:55 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-09 10:13:50 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-09 11:37:08 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/160912)
6 years, 6 months ago (2014-06-09 11:37:09 UTC) #8
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 6 months ago (2014-06-09 11:38:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/320523003/40001
6 years, 6 months ago (2014-06-09 11:38:47 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 12:57:21 UTC) #11
Message was sent while issue was closed.
Change committed as 275800

Powered by Google App Engine
This is Rietveld 408576698