Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 304153004: Center lock screen user pod when virtual keyboard is shown. (Closed)

Created:
6 years, 6 months ago by Nikita (slow)
Modified:
6 years, 6 months ago
CC:
chromium-reviews, arv+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Center lock screen user pod when virtual keyboard is shown. * Disable VK overscroll on lock screen * Pass VK bounds and on lock screen adjust outer-container size by modifying bottom style. Disable this feature with --disable-lock-scroll-into-view BUG=377904 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273630

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : add separate disable switch #

Total comments: 4

Patch Set 4 : expose login display type constants #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -49 lines) Patch
M chrome/browser/chromeos/login/helper.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/helper.cc View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/lock/webui_screen_locker.h View 1 6 chunks +21 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/lock/webui_screen_locker.cc View 1 2 7 chunks +82 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/core_oobe_actor.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/login/login_common.js View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/login/display_manager.js View 1 2 3 3 chunks +31 lines, -1 line 0 comments Download
M chrome/browser/resources/login/screen_container.css View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc View 1 2 3 2 chunks +15 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.h View 1 2 3 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 1 2 3 4 chunks +14 lines, -15 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/chromeos_switches.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nikita (slow)
6 years, 6 months ago (2014-05-29 15:06:31 UTC) #1
dzhioev (left Google)
On 2014/05/29 15:06:31, Nikita Kostylev wrote: LGTM with nits.
6 years, 6 months ago (2014-05-29 15:42:41 UTC) #2
dzhioev (left Google)
https://codereview.chromium.org/304153004/diff/40001/chrome/browser/resources/login/display_manager.js File chrome/browser/resources/login/display_manager.js (right): https://codereview.chromium.org/304153004/diff/40001/chrome/browser/resources/login/display_manager.js#newcode272 chrome/browser/resources/login/display_manager.js:272: clientArea.style.bottom = bottom + 'px'; nit: toCssPx(bottom) https://codereview.chromium.org/304153004/diff/40001/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc File ...
6 years, 6 months ago (2014-05-29 15:42:51 UTC) #3
Nikita (slow)
https://codereview.chromium.org/304153004/diff/40001/chrome/browser/resources/login/display_manager.js File chrome/browser/resources/login/display_manager.js (right): https://codereview.chromium.org/304153004/diff/40001/chrome/browser/resources/login/display_manager.js#newcode272 chrome/browser/resources/login/display_manager.js:272: clientArea.style.bottom = bottom + 'px'; On 2014/05/29 15:42:52, dzhioev ...
6 years, 6 months ago (2014-05-29 15:51:19 UTC) #4
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 6 months ago (2014-05-29 16:26:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/304153004/80001
6 years, 6 months ago (2014-05-29 16:29:34 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-05-29 22:43:25 UTC) #7
Message was sent while issue was closed. 
Change committed as 273630

Powered by Google App Engine
This is Rietveld 408576698