IPC::Channel: Reduce POSIX specific API surface

ipc/ipc_channel_posix.h

Index: ipc/ipc_channel_posix.h
diff --git a/ipc/ipc_channel_posix.h b/ipc/ipc_channel_posix.h
index ae2de72f7fe3fa582a90ff379efb4b043b68f1ad..fc7991d0ba2c0778d7c8168d93f5504390338f95 100644
--- a/ipc/ipc_channel_posix.h
+++ b/ipc/ipc_channel_posix.h
@@ -53,9 +53,11 @@ class ChannelPosix : public Channel,
                      public internal::ChannelReader,
                      public base::MessageLoopForIO::Watcher {
  public:
-  // Mirror methods of Channel, see ipc_channel.h for description.
-  ChannelPosix(const IPC::ChannelHandle& channel_handle, Mode mode,
-               Listener* listener);
+  // Implementation of IPC::Channel::Create()
+  static scoped_ptr<ChannelPosix> Create(

[jam, 2014/06/05 20:45:32]

I dont think a factory method for IPC::ChannelPosix is needed? the test can use
the constructor directly, since it's a test for this specific implementation

[gmorrita, 2014/06/05 22:05:25]

OK, removed the Create() and use the ctor directly.

+      const IPC::ChannelHandle& channel_handle, Mode mode,
+      Listener* listener);
+
   virtual ~ChannelPosix();
 
   // Channel implementation
@@ -65,10 +67,21 @@ class ChannelPosix : public Channel,
   virtual base::ProcessId GetPeerPID() const OVERRIDE;
   virtual int GetClientFileDescriptor() const OVERRIDE;
   virtual int TakeClientFileDescriptor() OVERRIDE;
-  virtual bool AcceptsConnections() const OVERRIDE;
-  virtual bool HasAcceptedConnection() const OVERRIDE;
-  virtual bool GetPeerEuid(uid_t* peer_euid) const OVERRIDE;
-  virtual void ResetToAcceptingConnectionState() OVERRIDE;
+
+  // Returns true if the channel supports listening for connections.
+  bool AcceptsConnections() const;
+
+  // Returns true if the channel supports listening for connections and is
+  // currently connected.
+  bool HasAcceptedConnection() const;
+
+  // Closes any currently connected socket, and returns to a listening state
+  // for more connections.
+  void ResetToAcceptingConnectionState();
+
+  // Returns true if the peer process' effective user id can be determined, in
+  // which case the supplied peer_euid is updated with it.
+  bool GetPeerEuid(uid_t* peer_euid) const;
 
   void CloseClientFileDescriptor();
 
@@ -78,6 +91,9 @@ class ChannelPosix : public Channel,
 #endif  // OS_LINUX
 
  private:
+  ChannelPosix(const IPC::ChannelHandle& channel_handle, Mode mode,
+               Listener* listener);
+
   bool CreatePipe(const IPC::ChannelHandle& channel_handle);
 
   bool ProcessOutgoingMessages();