IPC::Channel: Reduce POSIX specific API surface

ipc/ipc_channel_posix.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IPC_IPC_CHANNEL_POSIX_H_
 #define IPC_IPC_CHANNEL_POSIX_H_
 
 #include "ipc/ipc_channel.h"
 
 #include <sys/socket.h>  // for CMSG macros
@@ skipping 35 matching lines @@
 // needs to send file descriptors in later messages.
 #define IPC_USES_READWRITE 1
 #endif
 
 namespace IPC {
 
 class ChannelPosix : public Channel,
                      public internal::ChannelReader,
                      public base::MessageLoopForIO::Watcher {
  public:
-  // Mirror methods of Channel, see ipc_channel.h for description.
-  ChannelPosix(const IPC::ChannelHandle& channel_handle, Mode mode,
-               Listener* listener);
+  // Implementation of IPC::Channel::Create()
+  static scoped_ptr<ChannelPosix> Create(

[jam, 2014/06/05 20:45:32]

I dont think a factory method for IPC::ChannelPosix is needed? the test can use
the constructor directly, since it's a test for this specific implementation

[gmorrita, 2014/06/05 22:05:25]

OK, removed the Create() and use the ctor directly.

+      const IPC::ChannelHandle& channel_handle, Mode mode,
+      Listener* listener);
+
   virtual ~ChannelPosix();
 
   // Channel implementation
   virtual bool Connect() OVERRIDE;
   virtual void Close() OVERRIDE;
   virtual bool Send(Message* message) OVERRIDE;
   virtual base::ProcessId GetPeerPID() const OVERRIDE;
   virtual int GetClientFileDescriptor() const OVERRIDE;
   virtual int TakeClientFileDescriptor() OVERRIDE;
-  virtual bool AcceptsConnections() const OVERRIDE;
-  virtual bool HasAcceptedConnection() const OVERRIDE;
-  virtual bool GetPeerEuid(uid_t* peer_euid) const OVERRIDE;
-  virtual void ResetToAcceptingConnectionState() OVERRIDE;
+
+  // Returns true if the channel supports listening for connections.
+  bool AcceptsConnections() const;
+
+  // Returns true if the channel supports listening for connections and is
+  // currently connected.
+  bool HasAcceptedConnection() const;
+
+  // Closes any currently connected socket, and returns to a listening state
+  // for more connections.
+  void ResetToAcceptingConnectionState();
+
+  // Returns true if the peer process' effective user id can be determined, in
+  // which case the supplied peer_euid is updated with it.
+  bool GetPeerEuid(uid_t* peer_euid) const;
 
   void CloseClientFileDescriptor();
 
   static bool IsNamedServerInitialized(const std::string& channel_id);
 #if defined(OS_LINUX)
   static void SetGlobalPid(int pid);
 #endif  // OS_LINUX
 
  private:
+  ChannelPosix(const IPC::ChannelHandle& channel_handle, Mode mode,
+               Listener* listener);
+
   bool CreatePipe(const IPC::ChannelHandle& channel_handle);
 
   bool ProcessOutgoingMessages();
 
   bool AcceptConnection();
   void ClosePipeOnError();
   int GetHelloMessageProcId();
   void QueueHelloMessage();
   void CloseFileDescriptors(Message* msg);
   void QueueCloseFDMessage(int fd, int hops);
@@ skipping 115 matching lines @@
   // If non-zero, overrides the process ID sent in the hello message.
   static int global_pid_;
 #endif  // OS_LINUX
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(ChannelPosix);
 };
 
 }  // namespace IPC
 
 #endif  // IPC_IPC_CHANNEL_POSIX_H_