IPC::Channel: Reduce POSIX specific API surface

IPC::Channel: Reduce POSIX specific API surface

This change is a simple cleanup: It removes some Channel API
that is only used only in POSIX specific tests. These
funtions still live in ChannelPosix. POSIX speicific tests
now touch ChannelPosix instead of its superclass Channel.

TEST=none
R=darin@chromium.org, jam@chromium.org
BUG=377980
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275632

[jam, 2014-06-05 20:45:32]

https://codereview.chromium.org/320433002/diff/1/ipc/ipc_channel_posix.h
File ipc/ipc_channel_posix.h (right):

https://codereview.chromium.org/320433002/diff/1/ipc/ipc_channel_posix.h#newc...
ipc/ipc_channel_posix.h:57: static scoped_ptr<ChannelPosix> Create(
I dont think a factory method for IPC::ChannelPosix is needed? the test can use
the constructor directly, since it's a test for this specific implementation

[gmorrita, 2014-06-05 22:05:25]

PTAL?

https://codereview.chromium.org/320433002/diff/1/ipc/ipc_channel_posix.h
File ipc/ipc_channel_posix.h (right):

https://codereview.chromium.org/320433002/diff/1/ipc/ipc_channel_posix.h#newc...
ipc/ipc_channel_posix.h:57: static scoped_ptr<ChannelPosix> Create(
On 2014/06/05 20:45:32, jam wrote:
> I dont think a factory method for IPC::ChannelPosix is needed? the test can
use
> the constructor directly, since it's a test for this specific implementation

OK, removed the Create() and use the ctor directly.

[jam, 2014-06-06 14:47:13]

lgtm with nits

https://codereview.chromium.org/320433002/diff/20001/ipc/ipc_channel_posix.cc
File ipc/ipc_channel_posix.cc (right):

https://codereview.chromium.org/320433002/diff/20001/ipc/ipc_channel_posix.cc...
ipc/ipc_channel_posix.cc:1059: return ChannelPosix::Create(channel_handle, mode,
listener).PassAs<Channel>();
nit: i think you forgot to update this

https://codereview.chromium.org/320433002/diff/20001/ipc/ipc_channel_posix.h
File ipc/ipc_channel_posix.h (right):

https://codereview.chromium.org/320433002/diff/20001/ipc/ipc_channel_posix.h#...
ipc/ipc_channel_posix.h:58: 
nit: no blank line needed

[Hajime Morrita, 2014-06-06 20:23:29]

The CQ bit was checked by morrita@chromium.org

[commit-bot: I haz the power, 2014-06-06 20:24:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/morrita@chromium.org/320433002/40001

[Hajime Morrita, 2014-06-06 22:24:16]

The CQ bit was checked by morrita@chromium.org

[commit-bot: I haz the power, 2014-06-06 22:25:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/morrita@chromium.org/320433002/60001

[commit-bot: I haz the power, 2014-06-07 02:24:57]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-07 06:16:05]

Change committed as 275632