components/cdm/common/cdm_messages_android.h - Issue 320383005: Add an IPC to return the platform supported key-system names in Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cdm/common/cdm_messages_android.h

Issue 320383005: Add an IPC to return the platform supported key-system names in Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix nits. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cdm/browser/cdm_message_filter_android.cc ('K') | « components/cdm/browser/cdm_message_filter_android.cc ('k') | components/cdm/renderer/android_key_systems.h » ('j') | media/base/android/media_drm_bridge.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cdm/common/cdm_messages_android.h

diff --git a/components/cdm/common/cdm_messages_android.h b/components/cdm/common/cdm_messages_android.h

index e63f81b01cd8f9386da3ad1da8154cf2a0b98cda..738e10d3fb61769aeb0b7c19d2a92ad51a94abfe 100644

--- a/components/cdm/common/cdm_messages_android.h

+++ b/components/cdm/common/cdm_messages_android.h

@@ -29,8 +29,14 @@ IPC_STRUCT_END()

// Messages sent from the renderer to the browser.

-// Synchronously get a list of supported EME key systems.

+// Synchronously query a supported EME key system information.

ddorwin 2014/06/11 01:54:01 Synchronously query key system information. If the

ycheo (away) 2014/06/11 07:43:43 Done.

IPC_SYNC_MESSAGE_CONTROL1_1(

- ChromeViewHostMsg_GetSupportedKeySystems,

+ ChromeViewHostMsg_QueryKeySystemInfo,

SupportedKeySystemRequest /* key system information request */,

SupportedKeySystemResponse /* key system information response */)

+// Synchronously get a list of platform supported EME key system names

ddorwin 2014/06/11 01:54:01 nit: add a '-" before "supported" if that's really

ycheo (away) 2014/06/11 07:43:43 Done.

+// besides WideVine.

ddorwin 2014/06/11 01:54:01 My point was that these are a special class that a

ycheo (away) 2014/06/11 07:43:43 Done.

+IPC_SYNC_MESSAGE_CONTROL0_1(

+ ChromeViewHostMsg_GetPlatformKeySystemNames,

+ std::vector<std::string> /* key system names */)