components/cdm/common/cdm_messages_android.h - Issue 320383005: Add an IPC to return the platform supported key-system names in Android.

Side by Side Diff: components/cdm/common/cdm_messages_android.h

Issue 320383005: Add an IPC to return the platform supported key-system names in Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix nits. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/cdm/browser/cdm_message_filter_android.cc ('K') | « components/cdm/browser/cdm_message_filter_android.cc ('k') | components/cdm/renderer/android_key_systems.h » ('j') | media/base/android/media_drm_bridge.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // IPC messages for EME on android.	5 // IPC messages for EME on android.

6 // Multiply-included message file, hence no include guard.	6 // Multiply-included message file, hence no include guard.

7	7

8 #include <vector>	8 #include <vector>

9	9

10 #include "content/public/common/eme_codec.h"	10 #include "content/public/common/eme_codec.h"

(...skipping 11 matching lines...) Expand all Loading...
22 IPC_STRUCT_MEMBER(content::SupportedCodecs,	22 IPC_STRUCT_MEMBER(content::SupportedCodecs,

23 compositing_codecs,	23 compositing_codecs,

24 content::EME_CODEC_NONE)	24 content::EME_CODEC_NONE)

25 IPC_STRUCT_MEMBER(content::SupportedCodecs,	25 IPC_STRUCT_MEMBER(content::SupportedCodecs,

26 non_compositing_codecs,	26 non_compositing_codecs,

27 content::EME_CODEC_NONE)	27 content::EME_CODEC_NONE)

28 IPC_STRUCT_END()	28 IPC_STRUCT_END()

29	29

30 // Messages sent from the renderer to the browser.	30 // Messages sent from the renderer to the browser.

31	31

32 // Synchronously get a list of supported EME key systems.	32 // Synchronously query a supported EME key system information.
	ddorwin 2014/06/11 01:54:01 Synchronously query key system information. If the Synchronously query key system information. If the key system is supported, the response will be populated. (or something like that) ycheo (away) 2014/06/11 07:43:43 Done. Show quoted text On 2014/06/11 01:54:01, ddorwin wrote: > Synchronously query key system information. If the key system is supported, the > response will be populated. > (or something like that) Done.
33 IPC_SYNC_MESSAGE_CONTROL1_1(	33 IPC_SYNC_MESSAGE_CONTROL1_1(

34 ChromeViewHostMsg_GetSupportedKeySystems,	34 ChromeViewHostMsg_QueryKeySystemInfo,

35 SupportedKeySystemRequest /* key system information request */,	35 SupportedKeySystemRequest /* key system information request */,

36 SupportedKeySystemResponse /* key system information response */)	36 SupportedKeySystemResponse /* key system information response */)

	37

	38 // Synchronously get a list of platform supported EME key system names
	ddorwin 2014/06/11 01:54:01 nit: add a '-" before "supported" if that's really nit: add a '-" before "supported" if that's really what you mean. ycheo (away) 2014/06/11 07:43:43 Done. Show quoted text On 2014/06/11 01:54:01, ddorwin wrote: > nit: add a '-" before "supported" if that's really what you mean. Done.
	39 // besides WideVine.
	ddorwin 2014/06/11 01:54:01 My point was that these are a special class that a My point was that these are a special class that are not explicitly handled by Chrome (and thus unlikely to be spec compliant). If that was the case, then Widevine would obviously not be included. ycheo (away) 2014/06/11 07:43:43 Done. Show quoted text On 2014/06/11 01:54:01, ddorwin wrote: > My point was that these are a special class that are not explicitly handled by > Chrome (and thus unlikely to be spec compliant). If that was the case, then > Widevine would obviously not be included. Done.
	40 IPC_SYNC_MESSAGE_CONTROL0_1(

	41 ChromeViewHostMsg_GetPlatformKeySystemNames,

	42 std::vector<std::string> /* key system names */)

OLD	NEW