Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2238)

Unified Diff: ash/wm/overview/window_selector.h

Issue 320303002: Added UMA stats to overview mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed last nits. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/metrics/user_metrics_recorder.cc ('k') | ash/wm/overview/window_selector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/overview/window_selector.h
diff --git a/ash/wm/overview/window_selector.h b/ash/wm/overview/window_selector.h
index d6c85195ca1e66a59954c189483fa87222f0e6f3..f9ca51a64db03108ec88014ad5d1e8155fdc5d27 100644
--- a/ash/wm/overview/window_selector.h
+++ b/ash/wm/overview/window_selector.h
@@ -124,9 +124,6 @@ class ASH_EXPORT WindowSelector
// List of all the window overview grids, one for each root window.
ScopedVector<WindowGrid> grid_list_;
- // The time when overview was started.
- base::Time overview_start_time_;
-
// Tracks windows which were hidden because they were not part of the
// overview.
aura::WindowTracker hidden_windows_;
@@ -134,6 +131,17 @@ class ASH_EXPORT WindowSelector
// Tracks the index of the root window the selection widget is in.
size_t selected_grid_index_;
+ // The following variables are used for metric collection purposes. All of
+ // them refer to this particular overview session and are not cumulative:
+ // The time when overview was started.
+ base::Time overview_start_time_;
+
+ // The number of arrow key presses.
+ size_t num_key_presses_;
+
+ // The number of items in the overview.
+ size_t num_items_;
+
DISALLOW_COPY_AND_ASSIGN(WindowSelector);
};
« no previous file with comments | « ash/metrics/user_metrics_recorder.cc ('k') | ash/wm/overview/window_selector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698