Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: ash/metrics/user_metrics_recorder.cc

Issue 320303002: Added UMA stats to overview mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed last nits. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/metrics/user_metrics_recorder.h ('k') | ash/wm/overview/window_selector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/metrics/user_metrics_recorder.cc
diff --git a/ash/metrics/user_metrics_recorder.cc b/ash/metrics/user_metrics_recorder.cc
index 2ab9380d9dbfcde573d7c13d435d8b0585d369f0..377574508a0bf95e4565aa1254edb8ab03c0683a 100644
--- a/ash/metrics/user_metrics_recorder.cc
+++ b/ash/metrics/user_metrics_recorder.cc
@@ -368,9 +368,13 @@ void UserMetricsRecorder::RecordUserMetricsAction(UserMetricsAction action) {
base::RecordAction(
base::UserMetricsAction("WindowSelector_Overview"));
break;
- case ash::UMA_WINDOW_SELECTION:
+ case ash::UMA_WINDOW_OVERVIEW_ENTER_KEY:
base::RecordAction(
- base::UserMetricsAction("WindowSelector_Selection"));
+ base::UserMetricsAction("WindowSelector_OverviewEnterKey"));
+ break;
+ case ash::UMA_WINDOW_CYCLE:
+ base::RecordAction(
+ base::UserMetricsAction("WindowCycleController_Cycle"));
break;
}
}
@@ -401,7 +405,7 @@ void UserMetricsRecorder::RecordPeriodicMetrics() {
ACTIVE_WINDOW_STATE_TYPE_NO_ACTIVE_WINDOW;
wm::WindowState* active_window_state = ash::wm::GetActiveWindowState();
if (active_window_state) {
- switch(active_window_state->GetStateType()) {
+ switch (active_window_state->GetStateType()) {
case wm::WINDOW_STATE_TYPE_MAXIMIZED:
active_window_state_type = ACTIVE_WINDOW_STATE_TYPE_MAXIMIZED;
break;
« no previous file with comments | « ash/metrics/user_metrics_recorder.h ('k') | ash/wm/overview/window_selector.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698