Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 320293003: Revert 275819 "Add libxslt to the GN build" (Closed)

Created:
6 years, 6 months ago by ccameron
Modified:
6 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 275819 "Add libxslt to the GN build" This is causing compile failure on the Android build: http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20GN&number=3401 > Add libxslt to the GN build > > BUG= > R=scottmg@chromium.org > > Review URL: https://codereview.chromium.org/317253003 TBR=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275822

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -86 lines) Patch
M trunk/src/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/net/BUILD.gn View 1 chunk +4 lines, -5 lines 0 comments Download
D trunk/src/third_party/libxslt/BUILD.gn View 1 chunk +0 lines, -80 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ccameron
6 years, 6 months ago (2014-06-09 16:59:42 UTC) #1
ccameron
Committed patchset #1 manually as r275822 (tree was closed).
6 years, 6 months ago (2014-06-09 16:59:54 UTC) #2
brettw
6 years, 6 months ago (2014-06-09 17:04:07 UTC) #3
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698