Issue 317253003: Add libxslt to the GN build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 317253003: Add libxslt to the GN build (Closed)

Created:
6 years, 6 months ago by brettw

Modified:
6 years, 6 months ago

Reviewers:
scottmg

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add libxslt to the GN build BUG= R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275819

Patch Set 3 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -0 lines)			Patch
	M	BUILD.gn	View	1 2	2 chunks	+5 lines, -0 lines	0 comments	Download
	A	third_party/libxslt/BUILD.gn	View	1	1 chunk	+80 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scottmg

lgtm https://codereview.chromium.org/317253003/diff/1/third_party/libxslt/BUILD.gn File third_party/libxslt/BUILD.gn (right): https://codereview.chromium.org/317253003/diff/1/third_party/libxslt/BUILD.gn#newcode70 third_party/libxslt/BUILD.gn:70: include_dits = [ "mac" ] dits

6 years, 6 months ago (2014-06-06 15:32:34 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r275819.

Expand Messages | Collapse Messages

Issue 317253003: Add libxslt to the GN build (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages