Issue 3201004: Fix for pyauto dangerous downloads functional test.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3201004: Fix for pyauto dangerous downloads functional test. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 9 months ago by Alyssa

Modified:
4 years ago

Reviewers:
Nirnimesh

CC:
chromium-reviews, Paul Godavari, Paweł Hajdan Jr.

Visibility:
Public.

Description

Fix for pyauto dangerous downloads functional test. Added "dangerous downloads" files to data dir. Made sure the files were dangerous on each OS. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56911

Patch Set 1 #

Total comments: 2

Patch Set 2 : Real dmg #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
A	chrome/test/data/downloads/dangerous/dangerous.dmg	View	1	Binary file		0 comments	Download
A	chrome/test/data/downloads/dangerous/dangerous.exe	View		Binary file		0 comments	Download
M	chrome/test/functional/downloads.py	View		2 chunks	+9 lines, -4 lines	0 comments	Download

Trybot results:

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nirnimesh

http://codereview.chromium.org/3201004/diff/1/4 File chrome/test/functional/downloads.py (right): http://codereview.chromium.org/3201004/diff/1/4#newcode26 chrome/test/functional/downloads.py:26: return os.path.join(sub_path, 'dangerous.dmg') apparently you need a real dmg. ...

4 years, 9 months ago (2010-08-20 18:10:35 UTC) #2

Alyssa

Yes, .exe are dangerous on Linux. Uploaded a real dmg which should work.

4 years, 9 months ago (2010-08-20 18:32:03 UTC) #3

LGTM

Expand Messages | Collapse Messages