Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 320043003: Fixes a typo in notifications that prevented large image scaling. (Closed)

Created:
6 years, 6 months ago by dewittj
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Fixes a typo in notifications that prevented large image scaling. New test was added that ensures larger images are accepted. BUG=TBD Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276024

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2 lines) Patch
M chrome/renderer/extensions/notifications_native_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/notifications/api/basic_usage/background.js View 2 chunks +27 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
dewittj
ptal. BTW, are the native functions typically owned by api owners or by extensions/ owners?
6 years, 6 months ago (2014-06-09 21:59:06 UTC) #1
not at google - send to devlin
lgtm. you can own the native handlers if you want, though typically they're pretty shallow ...
6 years, 6 months ago (2014-06-09 22:03:46 UTC) #2
dewittj
The CQ bit was checked by dewittj@chromium.org
6 years, 6 months ago (2014-06-10 00:16:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dewittj@chromium.org/320043003/1
6 years, 6 months ago (2014-06-10 00:17:04 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-10 13:44:29 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-10 14:21:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/150349)
6 years, 6 months ago (2014-06-10 14:21:58 UTC) #7
dewittj
The CQ bit was checked by dewittj@chromium.org
6 years, 6 months ago (2014-06-10 14:25:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dewittj@chromium.org/320043003/1
6 years, 6 months ago (2014-06-10 14:27:52 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 14:46:40 UTC) #10
Message was sent while issue was closed.
Change committed as 276024

Powered by Google App Engine
This is Rietveld 408576698