chrome/renderer/extensions/notifications_native_handler.cc - Issue 320043003: Fixes a typo in notifications that prevented large image scaling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/notifications_native_handler.cc

Issue 320043003: Fixes a typo in notifications that prevented large image scaling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/notifications_native_handler.cc

diff --git a/chrome/renderer/extensions/notifications_native_handler.cc b/chrome/renderer/extensions/notifications_native_handler.cc

index a08284b2783a9454c82187e993c678d7afb8f9da..ba0e17a5252be0ad9b5141e9a4d828c647c4b18f 100644

--- a/chrome/renderer/extensions/notifications_native_handler.cc

+++ b/chrome/renderer/extensions/notifications_native_handler.cc

@@ -25,7 +25,7 @@ NotificationsNativeHandler::NotificationsNativeHandler(ScriptContext* context)

void NotificationsNativeHandler::GetNotificationImageSizes(

const v8::FunctionCallbackInfo<v8::Value>& args) {

- NotificationBitmapSizes bitmap_sizes = NotificationBitmapSizes();

+ NotificationBitmapSizes bitmap_sizes = GetNotificationBitmapSizes();

float scale_factor =

ui::GetScaleForScaleFactor(ui::GetSupportedScaleFactors().back());

« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/notifications/api/basic_usage/background.js » ('j') | no next file with comments »