Issue 319943003: [Android] Remove hardware menu button dragging support. (re-landing)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 319943003: [Android] Remove hardware menu button dragging support. (re-landing) (Closed)

Created:
6 years, 6 months ago by Kibeom Kim (inactive)

Modified:
6 years, 6 months ago

Reviewers:
aurimas (slooooooooow)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

[Android] Remove hardware menu button dragging support. (re-landing) This code path was broken sometime within a year, and we don't think it's worth to support this more. BUG=366154 Review URL: https://codereview.chromium.org/317083005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275395 0039d316-1c4b-4281-b951-d872f2087c98 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275630

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -233 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuDragHelper.java	View		13 chunks	+17 lines, -223 lines	0 comments	Download
	M	chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java	View		3 chunks	+5 lines, -10 lines	0 comments	Download

Total messages: 5 (0 generated)

Kibeom Kim (inactive)

forgot to notify gardener the downstream pair and reverted overnight. it's the same.

6 years, 6 months ago (2014-06-06 16:54:49 UTC) #1

aurimas (slooooooooow)

The CQ bit was checked by aurimas@chromium.org

6 years, 6 months ago (2014-06-06 20:50:05 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/319943003/1

6 years, 6 months ago (2014-06-06 20:52:05 UTC) #4

Message was sent while issue was closed.

Change committed as 275630