[Android] Remove hardware menu button dragging support.

[Android] Remove hardware menu button dragging support.

This code path was broken sometime within a year, and we don't think
it's worth to support this more.

BUG=366154
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275395

[Kibeom Kim (inactive), 2014-06-06 00:28:31]

Note: A regression that not dismissing the popup menu on the second hardware
menu button press, is not related to the dragging logic. We dismissed on
KEY_MENU button press inside AppMenu.java before, but sometime in the past the
code was removed.

[aurimas (slooooooooow), 2014-06-06 00:31:56]

LGTM.

Could we add back the code that dismisses the menu?

[Kibeom Kim (inactive), 2014-06-06 00:33:48]

On 2014/06/06 00:31:56, aurimas wrote:
> LGTM.
> 
> Could we add back the code that dismisses the menu?

yes sure I'll do as a separate CL. I guess we might have to merge back that.

[Kibeom Kim (inactive), 2014-06-06 00:36:06]

The CQ bit was checked by kkimlabs@chromium.org

[Ted C, 2014-06-06 00:38:36]

lgtm

https://codereview.chromium.org/317083005/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuDragHelper.java
(right):

https://codereview.chromium.org/317083005/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuDragHelper.java:98:
void onShow(boolean isByHardwareButton, boolean startDragging) {
can we get rid of isByHardwareButton?

[commit-bot: I haz the power, 2014-06-06 00:39:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/317083005/1

[Kibeom Kim (inactive), 2014-06-06 00:53:09]

https://codereview.chromium.org/317083005/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuDragHelper.java
(right):

https://codereview.chromium.org/317083005/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuDragHelper.java:98:
void onShow(boolean isByHardwareButton, boolean startDragging) {
On 2014/06/06 00:38:36, Ted C wrote:
> can we get rid of isByHardwareButton?

Done.

[Kibeom Kim (inactive), 2014-06-06 00:53:11]

The CQ bit was checked by kkimlabs@chromium.org

[commit-bot: I haz the power, 2014-06-06 00:55:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/317083005/20001

[commit-bot: I haz the power, 2014-06-06 11:05:32]

Change committed as 275395

[johnme, 2014-06-06 15:11:19]

A revert of this CL has been created in
https://codereview.chromium.org/317383002/ by johnme@chromium.org.

The reason for reverting is: AppMenuHandler.hardwareMenuButtonUp is still used
by clank/java/apps/chrome/src/com/google/android/apps/chrome/Main.java:1572,
hence this is causing instrumentation-yakju-clankium-tot and
clang-clankium-tot-builder to fail to compile with the following error:

../../../clank/java/apps/chrome/src/com/google/android/apps/chrome/Main.java:1572:
cannot find symbol
symbol  : method hardwareMenuButtonUp()
location: class org.chromium.chrome.browser.appmenu.AppMenuHandler
                mAppMenuHandler.hardwareMenuButtonUp();.