Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 319933002: IDL build: factor out global constructors action into a GYP template (Closed)

Created:
6 years, 6 months ago by Nils Barth (inactive)
Modified:
6 years, 6 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium, Nico, c.shu, brettw
Visibility:
Public.

Description

IDL build: factor out global constructors action into a GYP template Followup to: IDL build: factor out global objects action into a GYP template https://codereview.chromium.org/316173008/ R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175868

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix typo #

Patch Set 3 : Fix name collision #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -88 lines) Patch
M Source/bindings/core/generated.gyp View 1 chunk +12 lines, -30 lines 0 comments Download
M Source/bindings/modules/generated.gyp View 2 chunks +20 lines, -56 lines 0 comments Download
A Source/bindings/scripts/global_constructors.gypi View 1 2 1 chunk +73 lines, -0 lines 0 comments Download
M Source/bindings/scripts/global_objects.gypi View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Nils Barth (inactive)
6 years, 6 months ago (2014-06-06 07:24:35 UTC) #1
haraken
LGTM https://codereview.chromium.org/319933002/diff/1/Source/bindings/scripts/global_constructors.gypi File Source/bindings/scripts/global_constructors.gypi (right): https://codereview.chromium.org/319933002/diff/1/Source/bindings/scripts/global_constructors.gypi#newcode33 Source/bindings/scripts/global_constructors.gypi:33: # testing, which should not appear on global ...
6 years, 6 months ago (2014-06-06 07:30:44 UTC) #2
Nils Barth (inactive)
https://codereview.chromium.org/319933002/diff/1/Source/bindings/scripts/global_constructors.gypi File Source/bindings/scripts/global_constructors.gypi (right): https://codereview.chromium.org/319933002/diff/1/Source/bindings/scripts/global_constructors.gypi#newcode33 Source/bindings/scripts/global_constructors.gypi:33: # testing, which should not appear on global objects). ...
6 years, 6 months ago (2014-06-06 07:37:34 UTC) #3
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 6 months ago (2014-06-10 04:31:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/319933002/20001
6 years, 6 months ago (2014-06-10 04:32:46 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-10 05:39:47 UTC) #6
Nils Barth (inactive)
The CQ bit was unchecked by nbarth@chromium.org
6 years, 6 months ago (2014-06-10 06:04:14 UTC) #7
Nils Barth (inactive)
Turns out there was a bug, due to a name collision (only occurs if use ...
6 years, 6 months ago (2014-06-10 06:20:21 UTC) #8
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 6 months ago (2014-06-10 06:20:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/319933002/40001
6 years, 6 months ago (2014-06-10 06:20:43 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 07:27:48 UTC) #11
Message was sent while issue was closed. 
Change committed as 175868

Powered by Google App Engine
This is Rietveld 408576698