Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Unified Diff: Source/bindings/core/generated.gyp

Issue 319933002: IDL build: factor out global constructors action into a GYP template (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix name collision Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/modules/generated.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/generated.gyp
diff --git a/Source/bindings/core/generated.gyp b/Source/bindings/core/generated.gyp
index 25b18d663225a9e8dd0b15cb6ec9d280d5c15b1a..f9b0bbecf0bc3b964b8c6e8af6af6f1c38a1f149 100644
--- a/Source/bindings/core/generated.gyp
+++ b/Source/bindings/core/generated.gyp
@@ -29,45 +29,27 @@
################################################################################
{
'target_name': 'core_global_constructors_idls',
- 'type': 'none',
'dependencies': [
- 'core_global_objects',
+ 'core_global_objects',
],
- 'actions': [{
- 'action_name': 'generate_core_global_constructors_idls',
- 'inputs': [
- '<(bindings_scripts_dir)/generate_global_constructors.py',
- '<(bindings_scripts_dir)/utilities.py',
- # Only includes main IDL files (exclude dependencies and testing,
- # which should not appear on global objects).
- '<(core_idl_files_list)',
- '<@(core_idl_files)',
- '<(bindings_core_output_dir)/GlobalObjectsCore.pickle',
- ],
- 'outputs': [
- '<@(core_global_constructors_generated_idl_files)',
- '<@(core_global_constructors_generated_header_files)',
- ],
- 'action': [
- 'python',
- '<(bindings_scripts_dir)/generate_global_constructors.py',
- '--idl-files-list',
- '<(core_idl_files_list)',
- '--global-objects-file',
+ 'variables': {
+ 'idl_files': '<(core_idl_files)',
+ 'global_objects_file':
'<(bindings_core_output_dir)/GlobalObjectsCore.pickle',
- '--write-file-only-if-changed',
- '<(write_file_only_if_changed)',
- '--',
+ 'global_names_idl_files': [
'Window',
'<(blink_core_output_dir)/WindowCoreConstructors.idl',
'SharedWorkerGlobalScope',
'<(blink_core_output_dir)/SharedWorkerGlobalScopeCoreConstructors.idl',
'DedicatedWorkerGlobalScope',
'<(blink_core_output_dir)/DedicatedWorkerGlobalScopeCoreConstructors.idl',
- ],
- 'message':
- 'Generating IDL files for constructors on global objects from core',
- }]
+ ],
+ 'outputs': [
+ '<@(core_global_constructors_generated_idl_files)',
+ '<@(core_global_constructors_generated_header_files)',
+ ],
+ },
+ 'includes': ['../../bindings/scripts/global_constructors.gypi'],
},
################################################################################
{
« no previous file with comments | « no previous file | Source/bindings/modules/generated.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698