Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 319723002: Gracefully handling texture creation failure (Closed)

Created:
6 years, 6 months ago by sugoi1
Modified:
6 years, 6 months ago
CC:
chromium-reviews, cc-bugs_chromium.org, vangelis, senorblanco, rosca
Visibility:
Public.

Description

Gracefully handling texture creation failure For many reasons, something can go wrong within GrGpuGL::onCreateTexture() and fail to create the backing store's texture. Instead of crashing, we can handle this gracefully and simply render the page without the filter(s) applied. BUG=380407 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275285

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M cc/output/gl_renderer.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sugoi1
Adding enne@ to have an owner as reviewer.
6 years, 6 months ago (2014-06-05 15:33:53 UTC) #1
Stephen White
LGTM. Note that this is a subset of https://codereview.chromium.org/315913002. I think we should land this ...
6 years, 6 months ago (2014-06-05 16:34:18 UTC) #2
sugoi1
The CQ bit was checked by sugoi@chromium.org
6 years, 6 months ago (2014-06-05 17:05:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sugoi@chromium.org/319723002/1
6 years, 6 months ago (2014-06-05 17:06:17 UTC) #4
enne (OOO)
lgtm2, although an instant trace event would be nice as a warning that something bad ...
6 years, 6 months ago (2014-06-05 20:19:01 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-06-05 20:47:08 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 00:44:57 UTC) #7
Message was sent while issue was closed.
Change committed as 275285

Powered by Google App Engine
This is Rietveld 408576698