Check the texture allocation for offscreen render targets.

Use the factory to create SkGpuDevice objects.

SkGpuDevice constructors are deprecated and the factory should
be used instead when filters and blending require offscreen targets.

Extra NULL check added: for many reasons, something can go wrong
within GrGpuGL::onCreateTexture() and fail to create the backing
store's texture. Instead of crashing, we can handle this gracefully
and simply render the page without the blending applied.



BUG=359947
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275553

[rosca, 2014-06-04 08:30:38]

Hi, could you please review this?

[Stephen White, 2014-06-05 16:36:10]

LGTM, but please let the smaller subset
https://codereview.chromium.org/319723002/ land first, so it can be merged
independently.

[sugoi1, 2014-06-06 12:48:37]

On 2014/06/05 16:36:10, Stephen White wrote:
> LGTM, but please let the smaller subset
> https://codereview.chromium.org/319723002/ land first, so it can be merged
independently.

The other patch has landed. You'll need to update to tip of tree before landing
this.

[rosca, 2014-06-06 12:51:58]

On 2014/06/06 12:48:37, sugoi1 wrote:
> On 2014/06/05 16:36:10, Stephen White wrote:
> > LGTM, but please let the smaller subset
> > https://codereview.chromium.org/319723002/ land first, so it can be merged
> independently.
> 
> The other patch has landed. You'll need to update to tip of tree before
landing
> this.

Will do so, thanks.

[danakj, 2014-06-06 14:17:46]

LGTM for the factory change but please update the description

[rosca, 2014-06-06 16:43:58]

On 2014/06/06 14:17:46, danakj wrote:
> LGTM for the factory change but please update the description

Thanks, I updated the patch and I added instant trace events as a warning that
something bad was happening.

[danakj, 2014-06-06 17:31:43]

LGTM

[rosca, 2014-06-06 17:49:31]

The CQ bit was checked by rosca@adobe.com

[commit-bot: I haz the power, 2014-06-06 17:51:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rosca@adobe.com/315913002/20001

[commit-bot: I haz the power, 2014-06-06 19:41:54]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-06 23:37:41]

Change committed as 275553