Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 319673002: De-flake only-valid-drop-targets-receive-file-drop. (Closed)

Created:
6 years, 6 months ago by mkosiba (inactive)
Modified:
6 years, 6 months ago
Reviewers:
dglazkov
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

De-flake only-valid-drop-targets-receive-file-drop. Looks like after Blink r175269 the moment where the test runner grabs the text dump may occur after the quick-fail timer. I've only been able to repro it once out of about 40 invocations so I can only speculate that the navigation which we cancel in beforeunload is somethimes delaying the test's completion long enough for the deadman's switch to fire. Since the order of events is correct even in the failing case it's relatively simple to make the test pass regardless of whether the test runner grabs the text dump before or after the timer fires. BUG=380151 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175696

Patch Set 1 #

Patch Set 2 : remove entry from expectations #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : dont update test expectations, it's impossible to land changes with CQ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M LayoutTests/fast/events/only-valid-drop-targets-receive-file-drop.html View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 25 (0 generated)
mkosiba (inactive)
PTAL
6 years, 6 months ago (2014-06-05 08:33:12 UTC) #1
dglazkov
lgtm
6 years, 6 months ago (2014-06-05 15:05:08 UTC) #2
mkosiba (inactive)
The CQ bit was checked by mkosiba@chromium.org
6 years, 6 months ago (2014-06-06 07:40:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/319673002/20001
6 years, 6 months ago (2014-06-06 07:41:23 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 07:41:29 UTC) #5
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 6 months ago (2014-06-06 07:41:30 UTC) #6
mkosiba (inactive)
The CQ bit was checked by mkosiba@chromium.org
6 years, 6 months ago (2014-06-06 07:54:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/319673002/30001
6 years, 6 months ago (2014-06-06 07:54:45 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-06 09:03:00 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 09:04:13 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/8365)
6 years, 6 months ago (2014-06-06 09:04:15 UTC) #11
mkosiba (inactive)
The CQ bit was checked by mkosiba@chromium.org
6 years, 6 months ago (2014-06-06 09:45:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/319673002/30001
6 years, 6 months ago (2014-06-06 09:46:16 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-06 09:49:03 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 09:50:18 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/8374)
6 years, 6 months ago (2014-06-06 09:50:19 UTC) #16
mkosiba (inactive)
The CQ bit was checked by mkosiba@chromium.org
6 years, 6 months ago (2014-06-06 15:52:56 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/319673002/50001
6 years, 6 months ago (2014-06-06 15:53:06 UTC) #18
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-06 17:08:24 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 17:09:36 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10624)
6 years, 6 months ago (2014-06-06 17:09:37 UTC) #21
mkosiba (inactive)
The CQ bit was checked by mkosiba@chromium.org
6 years, 6 months ago (2014-06-06 17:34:27 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/319673002/70001
6 years, 6 months ago (2014-06-06 17:35:11 UTC) #23
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-06-06 18:40:38 UTC) #24
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 19:36:35 UTC) #25
Message was sent while issue was closed.
Change committed as 175696

Powered by Google App Engine
This is Rietveld 408576698