|
|
Created:
6 years, 6 months ago by mkosiba (inactive) Modified:
6 years, 6 months ago Reviewers:
dglazkov CC:
blink-reviews Base URL:
https://chromium.googlesource.com/chromium/blink.git@master Visibility:
Public. |
DescriptionDe-flake only-valid-drop-targets-receive-file-drop.
Looks like after Blink r175269 the moment where the test runner
grabs the text dump may occur after the quick-fail timer.
I've only been able to repro it once out of about 40 invocations
so I can only speculate that the navigation which we cancel in
beforeunload is somethimes delaying the test's completion long
enough for the deadman's switch to fire.
Since the order of events is correct even in the failing case
it's relatively simple to make the test pass regardless of whether
the test runner grabs the text dump before or after the timer fires.
BUG=380151
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175696
Patch Set 1 #Patch Set 2 : remove entry from expectations #Patch Set 3 : rebase #Patch Set 4 : rebase #Patch Set 5 : dont update test expectations, it's impossible to land changes with CQ #
Messages
Total messages: 25 (0 generated)
PTAL
lgtm
The CQ bit was checked by mkosiba@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/319673002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file LayoutTests/TestExpectations Hunk #1 FAILED at 1065. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/TestExpectations.rej Patch: LayoutTests/TestExpectations Index: LayoutTests/TestExpectations diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations index ed8c7fd65bd98ceac2f94312aca570a146fd689a..c8779962bede2bc02b7838d2276016e95fe0bda1 100644 --- a/LayoutTests/TestExpectations +++ b/LayoutTests/TestExpectations @@ -1065,8 +1065,6 @@ crbug.com/376194 inspector/console/console-format-es6.html [ Skip ] crbug.com/376194 inspector/console/console-format-es6-symbols-error.html [ Skip ] crbug.com/376194 inspector/console/console-dir-es6.html [ Skip ] -crbug.com/380151 fast/events/only-valid-drop-targets-receive-file-drop.html [ Failure Pass ] - crbug.com/380167 [ Mac ] plugins/destroy-reentry.html [ Failure Pass ] crbug.com/380649 [ Mac ] fast/dom/HTMLScriptElement/dont-load-unknown-type.html [ Failure ]
The CQ bit was checked by mkosiba@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/319673002/30001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...) mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...) mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10553)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)
The CQ bit was checked by mkosiba@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/319673002/30001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...) mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)
The CQ bit was checked by mkosiba@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/319673002/50001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...) linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...) mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...) mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10607)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10624)
The CQ bit was checked by mkosiba@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/319673002/70001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7183) win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/11027)
Message was sent while issue was closed.
Change committed as 175696 |