Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: LayoutTests/fast/events/only-valid-drop-targets-receive-file-drop.html

Issue 319673002: De-flake only-valid-drop-targets-receive-file-drop. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: dont update test expectations, it's impossible to land changes with CQ Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/events/only-valid-drop-targets-receive-file-drop.html
diff --git a/LayoutTests/fast/events/only-valid-drop-targets-receive-file-drop.html b/LayoutTests/fast/events/only-valid-drop-targets-receive-file-drop.html
index 0ef77a214e959e2ae284c3ddb91fd82e6a6b8f62..13b4252c8d24b52d96c2e372dabef1138a3f15b5 100644
--- a/LayoutTests/fast/events/only-valid-drop-targets-receive-file-drop.html
+++ b/LayoutTests/fast/events/only-valid-drop-targets-receive-file-drop.html
@@ -8,6 +8,7 @@ div, span {
</style>
<script>
var dropReceived;
+var beforeUnloadReceived = false;
function log(str)
{
var result = document.getElementById('result');
@@ -57,16 +58,17 @@ window.onload = function()
window.addEventListener('beforeunload', function (e) {
if (!dropReceived)
log('Drop not received');
+ beforeUnloadReceived = true;
e.preventDefault();
testRunner.notifyDone();
});
dragDrop(drop1);
- unloadExpected = true;
dragDrop(drop2);
window.setTimeout(function () {
// Deadman's switch to fail quickly.
- log('FAIL: navigation expected');
+ if (!beforeUnloadReceived)
+ log('FAIL: navigation expected');
testRunner.notifyDone();
}, 0);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698